Bump to Lucene99

[mch2]

Description

Bump Lucene to Version 9.9.1

Related Issues

Resolves #11414

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 9024bdb

Incompatible components

Incompatible components: [https:/opensearch-project/security-analytics.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/notifications.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/index-management.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/security.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/alerting.git, https:/opensearch-project/sql.git]

[github-actions]

❌ Gradle check result for 26f9fc6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[msfroh]

@gashutos -- I suspect you know more about the pruning logic than any of us. Can you confirm that we're doing this properly?

Thanks!

[gashutos]

@gashutos -- I suspect you know more about the pruning logic than any of us. Can you confirm that we're doing this properly?

Thanks!

@msfroh @mch2 Changes look correct to me. We need to address filterPruning helper in comparatorSource as @msfroh suggested.
Very surprising that small change in Lucene is introducing API breaks (compile time). Could have been better

[github-actions]

❌ Gradle check result for 98b3098: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mch2]

@gashutos @msfroh Thanks for the review here, latest revision handles the comparatorSource changes .

Still working through some unit failures, theres a break in some concurrent search related tests that mocked a now final IndexSearcher#getSlices.

[github-actions]

❌ Gradle check result for 6a97ffa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[gashutos]

Looks good !

[github-actions]

❌ Gradle check result for 1c3d186: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 63b75f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 286514d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[reta]

Thanks a lot for doing that @mch2 !

[reta]

@msfroh could you please look at this change as well? (Lucene 9.9.1 update) thank you

[github-actions]

❌ Gradle check result for 0185041: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 0185041:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 9024bdb:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mch2]

check seems to be having issues - latest run finished with Finished: UNSTABLE but did not report as such. re-firing

[github-actions]

✅ Gradle check result for 9024bdb: SUCCESS

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11421-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4a42150ba0cbf10022797c038f35faaea2f548f6
# Push it to GitHub
git push --set-upstream origin backport/backport-11421-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11421-to-2.x.