-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported version for max_shard_size parameter in Shrink API #11439
Conversation
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Compatibility status:Checks if related components are compatible with change a6bd35a Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https:/opensearch-project/security-analytics.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/notifications.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/index-management.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/sql.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11439 +/- ##
============================================
+ Coverage 71.35% 71.46% +0.10%
- Complexity 59201 59205 +4
============================================
Files 4906 4906
Lines 278198 278198
Branches 40422 40422
============================================
+ Hits 198520 198802 +282
+ Misses 63229 62897 -332
- Partials 16449 16499 +50 ☔ View full report in Codecov by Sentry. |
❕ Gradle check result for a17b746: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
rest-api-spec/src/main/resources/rest-api-spec/test/indices.shrink/40_max_shard_size.yml
Show resolved
Hide resolved
@gaobinlong When you get a change could you resolve the merge conflicts and we can see about getting this in? |
Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for a6bd35a: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11439-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 60b2265d9390f27f80803f16eb4d1c5cdc0f4947
# Push it to GitHub
git push --set-upstream origin backport/backport-11439-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@gaobinlong please create a manual backport to 2.x if needed, thank you. |
…pensearch-project#11439) * Update supported version for max_shard_size parameter in Shrink API Signed-off-by: Gao Binlong <[email protected]> * Modify changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]>
…pensearch-project#11439) * Update supported version for max_shard_size parameter in Shrink API Signed-off-by: Gao Binlong <[email protected]> * Modify changelog Signed-off-by: Gao Binlong <[email protected]> --------- Signed-off-by: Gao Binlong <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
After the new added parameter
max_shard_size
for shrink API was backported and released in 2.5.0, we need to correct the supported version in the yml rest test file, change it from 3.0.0 to 2.5.0.Related Issues
Part of #5229
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.