Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported version for must_exist parameter in update aliases API #11872

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Jan 12, 2024

Description

This PR enables the parameter must_exist in update aliases API and will be release in 2.12.0, in order to ensure the backward compatibility checks pass, the supported version in yaml test file was set to 3.0.0 in that PR, after the PR was merged and backport to 2.x, we need to update the supported version to 2.12.0 in main branch so that the backward compatibility checks can cover the change.

Backport 2.x is not needed.

Related Issues

#2949

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Compatibility status:

Checks if related components are compatible with change 3db976b

Incompatible components

Incompatible components: [https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/sql.git, https:/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security-analytics.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/notifications.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/security.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/index-management.git, https:/opensearch-project/alerting.git]

Copy link
Contributor

❌ Gradle check result for 840a83f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

❌ Gradle check result for 6895233: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 3db976b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8ae7f0) 71.35% compared to head (3db976b) 71.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11872      +/-   ##
============================================
+ Coverage     71.35%   71.49%   +0.13%     
- Complexity    59332    59428      +96     
============================================
  Files          4921     4921              
  Lines        278989   278989              
  Branches      40543    40543              
============================================
+ Hits         199068   199457     +389     
+ Misses        63420    62980     -440     
- Partials      16501    16552      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta self-requested a review January 13, 2024 14:16
@reta reta merged commit 988dea8 into opensearch-project:main Jan 13, 2024
33 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…PI (opensearch-project#11872)

* Update supported version for must_exist parameter in update aliases API

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…PI (opensearch-project#11872)

* Update supported version for must_exist parameter in update aliases API

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…PI (opensearch-project#11872)

* Update supported version for must_exist parameter in update aliases API

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
@reta reta mentioned this pull request Jul 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants