[Backport 2.x] Allow composite aggregation under filter or reverse_nested parent #12151
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Compatibility status:Checks if related components are compatible with change b7debe5 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https:/opensearch-project/custom-codecs.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/flow-framework.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/observability.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/notifications.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/reporting.git, https:/opensearch-project/sql.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/index-management.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/security.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/alerting.git, https:/opensearch-project/performance-analyzer.git] |
|
❌ Gradle check result for babb238: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for babb238: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #12151 +/- ##
============================================
- Coverage 71.21% 71.19% -0.03%
+ Complexity 60004 59974 -30
============================================
Files 4944 4944
Lines 282197 282197
Branches 41335 41335
============================================
- Hits 200969 200912 -57
- Misses 64241 64284 +43
- Partials 16987 17001 +14 ☔ View full report in Codecov by Sentry. |
…1499) * Allow composite aggregation under filter parent Composite aggregations are able to run under a filter aggregation with no change required (other than not throwing an exception). Also cleaned up FilterAggregatorFactory a little. Signed-off-by: Michael Froh <[email protected]> * Add changelog entry Signed-off-by: Michael Froh <[email protected]> * Add support for reverse nested agg too Signed-off-by: Michael Froh <[email protected]> * Add unit test coverage Signed-off-by: Michael Froh <[email protected]> * Skip new tests in pre-3.0 mixed cluster Signed-off-by: Michael Froh <[email protected]> --------- Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit 24b0cc9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
force-pushed
the
backport/backport-11499-to-2.x
branch
from
babb238
to
b7debe5
Compare
|
❌ Gradle check result for b7debe5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for b7debe5: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Backport 24b0cc9 from #11499.