Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString() to MultiSearchRequest, MultiGetRequest and CreateIndex… #12314

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add toString() to MultiSearchRequest, MultiGetRequest and CreateIndex… #12314

merged 1 commit into from
Feb 14, 2024

Conversation

guillaume-alvarez
Copy link
Contributor

fix #12144

Description

Make debugging easier with toString() method in MultiSearchRequest class.

backport of #12163

Related Issues

Resolves #12144

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5244107

Incompatible components

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/custom-codecs.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/flow-framework.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/reporting.git, https:/opensearch-project/observability.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/notifications.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/alerting.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/index-management.git, https:/opensearch-project/sql.git, https:/opensearch-project/security.git, https:/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 5244107: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@guillaume-alvarez
Copy link
Contributor Author

1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
is covered by #9191

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2da8718) 71.27% compared to head (5244107) 71.10%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12314      +/-   ##
============================================
- Coverage     71.27%   71.10%   -0.18%     
+ Complexity    60027    59915     -112     
============================================
  Files          4944     4944              
  Lines        282197   282200       +3     
  Branches      41335    41335              
============================================
- Hits         201131   200652     -479     
- Misses        64018    64566     +548     
+ Partials      17048    16982      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross added the backport 2.x Backport to 2.x branch label Feb 14, 2024
@andrross andrross merged commit 04037cd into opensearch-project:2.x Feb 14, 2024
82 of 84 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-12314-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 04037cdd807c0a99ba4c7c381c389f13b1a592fe
# Push it to GitHub
git push --set-upstream origin backport/backport-12314-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12314-to-2.x.

@andrross
Copy link
Member

andrross commented Feb 14, 2024

@guillaume-alvarez Do you mind putting together the manual backport PR as described above?

@kotwanikunal
Copy link
Member

@andrross This was the backport PR :)

@andrross
Copy link
Member

Lol, sorry @guillaume-alvarez, ignore me please.

@andrross andrross removed the backport 2.x Backport to 2.x branch label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Clients Clients within the Core repository such as High level Rest client and low level client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants