Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Derived Fields] Add support for emitting multiple values in DerivedFieldScripts #12837

Merged
merged 16 commits into from
Apr 3, 2024
Merged

[Derived Fields] Add support for emitting multiple values in DerivedFieldScripts #12837

merged 16 commits into from
Apr 3, 2024

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Mar 21, 2024 •
edited by msfroh
Loading

Description

Adds support for emitting multiple values when using the script context for derived field scripts.

Related Issues

Required to resolve #12508

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change bddcfe1

Incompatible components

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/custom-codecs.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/flow-framework.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/notifications.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/observability.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/reporting.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/index-management.git, https:/opensearch-project/sql.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/alerting.git, https:/opensearch-project/security.git, https:/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c99133d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

qreshi and others added 11 commits April 2, 2024 12:30
@qreshi @rishabhmaurya
Create allowlist file for ScriptEmitValues emit functions
60481a4 
Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Register DerivedFieldScript's context and allowed functions
2f6c656 
Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Update ScriptEmitValues to just emit basic types
67d7dc7 
Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Rename emit functions to be unique based on type to temporarily work …
158f575 
…around binding conflicts

Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Add initial tests for DerivedFieldScript
de99f7a 
Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Rename EmitValues subclass for String to avoid naming conflict with p…
4273156 
…rimitive type

Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
In progress unit testing for DerivedFieldScript
befa907 
Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi @rishabhmaurya
Add tests for DerivedFieldScript
e1a7421 
Signed-off-by: Mohammad Qureshi <[email protected]>
@rishabhmaurya
Spotless fixes
c703767 
Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya
Use emitted values instead of directly using script.execute() in Valu…
80a6dd4 
…eFetcher

Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya
Fix javadoc check failures
5e4c26c 
Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya
Fix license
4ff749f 
Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya
Add limits to emitted values from DerivedFieldScript
15a2600 
Signed-off-by: Rishabh Maurya <[email protected]>
@rishabhmaurya
Fix test after rebase
bddcfe1 
Signed-off-by: Rishabh Maurya <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

✅ Gradle check result for 5cc097d: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

❕ Gradle check result for dc6b396: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

✅ Gradle check result for bddcfe1: SUCCESS

@msfroh msfroh merged commit e8c5daf into opensearch-project:main Apr 3, 2024
37 of 46 checks passed
@rishabhmaurya rishabhmaurya added the backport 2.x Backport to 2.x branch label Apr 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2024
@github-actions @rishabhmaurya
[Derived Fields] Add support for emitting multiple values in DerivedF…
49a4e32 
…ieldScripts (#12837)

---------

Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
(cherry picked from commit e8c5daf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 4, 2024
Closed
This was referenced Apr 4, 2024
Merged
Merged
msfroh pushed a commit that referenced this pull request Apr 5, 2024
@rishabhmaurya @github-actions
[Backport 2.x] [Derived Fields] Add support for emitting multiple val…
80f31cf 
…ues in DerivedFieldScripts (#13083)

* [Derived Fields] Add support for emitting multiple values in DerivedFieldScripts (#12837)

---------

Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
(cherry picked from commit e8c5daf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Change allowlist to whitelist in 2.x to address conflicts

Signed-off-by: Rishabh Maurya <[email protected]>

---------

Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@rishabhmaurya rishabhmaurya mentioned this pull request Apr 11, 2024
Open
6 tasks
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@qreshi @rishabhmaurya @shiv0408
[Derived Fields] Add support for emitting multiple values in DerivedF…
e868b21 
…ieldScripts (opensearch-project#12837)

---------

Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Rishabh Maurya <[email protected]>
Co-authored-by: Rishabh Maurya <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhmaurya rishabhmaurya rishabhmaurya left review comments

@msfroh msfroh msfroh approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Derived Fields] Add basic query support with derived fields
3 participants
@qreshi @msfroh @rishabhmaurya