Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Routing Table] Initial commit for RemoteRoutingTableService setup #13304

Merged
merged 19 commits into from
Jun 5, 2024

Conversation

himshikha
Copy link
Contributor

@himshikha himshikha commented Apr 19, 2024

Description

This change is for setting up base service for remote routing table operations.

  • Adds interfaces for remote upload/download operations
  • Adds node attributes for enabling Remote routing table repo.
  • Adds FeatureFlag for Remote routing table feature to keep as experimental feature for now.

Related Issues

Resolves (#13049)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 725b2bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directionally looks fine from keeping a separate repo and gating the feature behind a feature flag. We would need some integration and basic tests before we can consider merging this change in

@Bukhtawar Bukhtawar marked this pull request as draft April 19, 2024 10:13
@himshikha himshikha changed the title Initial commit for RemoteRoutingTableService setup [Remote Routing Table]Initial commit for RemoteRoutingTableService setup Apr 19, 2024
@himshikha himshikha changed the title [Remote Routing Table]Initial commit for RemoteRoutingTableService setup [Remote Routing Table] Initial commit for RemoteRoutingTableService setup Apr 19, 2024
Copy link
Contributor

❌ Gradle check result for d5a17ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale merged commit 5121409 into opensearch-project:main Jun 5, 2024
37 of 40 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13304-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51214092ca532b557b6775ff8620025a51f92fcc
# Push it to GitHub
git push --set-upstream origin backport/backport-13304-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13304-to-2.x.

LantaoJin pushed a commit to LantaoJin/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 6, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 7, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Jun 8, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 5121409)
Bukhtawar pushed a commit that referenced this pull request Jun 8, 2024
…3304) (#14026)

* [Remote Routing Table] Introducing RemoteRoutingTableService (#13304)

Signed-off-by: Himshikha Gupta <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ensearch-project#13304) (opensearch-project#14026)

* [Remote Routing Table] Introducing RemoteRoutingTableService (opensearch-project#13304)

Signed-off-by: Himshikha Gupta <[email protected]>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…etup (opensearch-project#13304)

* Initial commit for RemoteRoutingTableService setup

Signed-off-by: Himshikha Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants