Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cluster publish timeout in flaky test testStaleClusterManage… #13463

Merged
merged 1 commit into from
May 2, 2024

Conversation

rahulkarajgikar
Copy link
Contributor

@rahulkarajgikar rahulkarajgikar commented Apr 30, 2024

Description

Addresses fix for Flaky Test testStaleClusterManagerNotHijackingMajority which is caused in scenarios of Cluster State not being able to publish within configured timeout of 1s

This change increases the time limit to 2s.

Related Issues

Resolves #1565

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rNotHijackingMajority

Signed-off-by: Rahul Karajgikar <[email protected]>
Copy link
Contributor

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Apr 30, 2024

@kkmr do examine and comment on flaky tests when you see a gradle build failure when you see it before hitting approve ;)

@dblock
Copy link
Member

dblock commented Apr 30, 2024

Copy link
Contributor

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkmr
Copy link
Contributor

kkmr commented Apr 30, 2024

@kkmr do examine and comment on flaky tests when you see a gradle build failure when you see it before hitting approve ;)

Will add to my workflow :-)

Copy link
Contributor

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rahulkarajgikar
Copy link
Contributor Author

rahulkarajgikar commented Apr 30, 2024

https://build.ci.opensearch.org/job/gradle-check/38095/

1 failed test causing gradle check to fail:

[org.opensearch.indices.CacheStatsAPIIndicesRequestCacheIT.testNullLevels {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/38095/testReport/junit/org.opensearch.indices/CacheStatsAPIIndicesRequestCacheIT/testNullLevels__p0___opensearch_experimental_feature_pluggable_caching_enabled___true___/)

known flaky test: #13458

Copy link
Contributor

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented May 1, 2024

❌ Gradle check result for 0851f2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric

This looks like a new one, @rahulkarajgikar care to take a look, open a new issue if it's unrelated, pls?

@rahulkarajgikar
Copy link
Contributor Author

looks unrelated since i just increased timeout in test.

Created a new issue for this: #13504

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for 882eb4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for c6d19a7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

❌ Gradle check result for 504d9e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 2, 2024

✅ Gradle check result for 0851f2e: SUCCESS

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (b15cb0c) to head (0851f2e).
Report is 250 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13463      +/-   ##
============================================
+ Coverage     71.42%   71.49%   +0.07%     
- Complexity    59978    60945     +967     
============================================
  Files          4985     5049      +64     
  Lines        282275   286682    +4407     
  Branches      40946    41529     +583     
============================================
+ Hits         201603   204977    +3374     
- Misses        63999    64731     +732     
- Partials      16673    16974     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owaiskazi19 owaiskazi19 merged commit 3b0cd0a into opensearch-project:main May 2, 2024
86 of 115 checks passed
@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label May 2, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 2, 2024
…rNotHijackingMajority (#13463)

Signed-off-by: Rahul Karajgikar <[email protected]>
Co-authored-by: Rahul Karajgikar <[email protected]>
(cherry picked from commit 3b0cd0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…rNotHijackingMajority (opensearch-project#13463)

Signed-off-by: Rahul Karajgikar <[email protected]>
Co-authored-by: Rahul Karajgikar <[email protected]>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…rNotHijackingMajority (opensearch-project#13463)

Signed-off-by: Rahul Karajgikar <[email protected]>
Co-authored-by: Rahul Karajgikar <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…rNotHijackingMajority (opensearch-project#13463)

Signed-off-by: Rahul Karajgikar <[email protected]>
Co-authored-by: Rahul Karajgikar <[email protected]>
@dblock
Copy link
Member

dblock commented Jul 23, 2024

Looks like the backport in #13513 never happened, @rahulkarajgikar can you please make sure it is backported?

dblock pushed a commit that referenced this pull request Oct 1, 2024
…rNotHijackingMajority (#13463) (#13513)

(cherry picked from commit 3b0cd0a)

Signed-off-by: Rahul Karajgikar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rahul Karajgikar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run skip-changelog
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG] StableClusterManagerDisruptionIT.testStaleClusterManagerNotHijackingMajority (Random Test Failure)
4 participants