Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mockito from 5.11.0 to 5.12.0 #13665

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 14, 2024

Description

Bump mockito from 5.11.0 to 5.12.0

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@reta reta added skip-changelog backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file and removed skip-changelog labels May 14, 2024
@prudhvigodithi
Copy link
Contributor

Coming from opensearch-project/job-scheduler#628 (comment), this change LGTM. Thanks @cwperks.

Copy link
Contributor

❌ Gradle check result for c378960: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 916457c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 14, 2024

❌ Gradle check result for 916457c: FAILURE

#13600

Copy link
Contributor

❕ Gradle check result for 916457c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (b15cb0c) to head (916457c).
Report is 282 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13665      +/-   ##
============================================
+ Coverage     71.42%   71.63%   +0.21%     
- Complexity    59978    61230    +1252     
============================================
  Files          4985     5059      +74     
  Lines        282275   287521    +5246     
  Branches      40946    41646     +700     
============================================
+ Hits         201603   205974    +4371     
- Misses        63999    64580     +581     
- Partials      16673    16967     +294     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member Author

cwperks commented May 15, 2024

Why is detect-breaking-change not running on this PR?

@reta
Copy link
Collaborator

reta commented May 15, 2024

Why is detect-breaking-change not running on this PR?

There were some experiments with mandatory checks on repo setting,s, could you please rebase / merge with main and repush? Thank you. Scratch that please, it is still not being run ....

@reta reta merged commit febe8c7 into opensearch-project:main May 15, 2024
41 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 15, 2024
* Bump mockito from 5.11.0 to 5.12.0

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit febe8c7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 16, 2024
* Bump mockito from 5.11.0 to 5.12.0



* Add to CHANGELOG



---------


(cherry picked from commit febe8c7)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
* Bump mockito from 5.11.0 to 5.12.0

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
* Bump mockito from 5.11.0 to 5.12.0

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants