Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.14] Check changed files before running gradle check #13952

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 0c0a2b3 from #13498.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Gradle check result for ffa13eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 3, 2024

❌ Gradle check result for ffa13eb: FAILURE

#13504, fixed by not backported

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Gradle check result for ffa13eb: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❌ Gradle check result for ffa13eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 4, 2024

❌ Gradle check result for ffa13eb: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 4, 2024

❕ Gradle check result for ffa13eb: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Sayali Gaikawad <[email protected]>
(cherry picked from commit 0c0a2b3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta force-pushed the backport/backport-13498-to-2.14 branch from ffa13eb to a9ff2bf Compare June 4, 2024 20:14
Copy link
Contributor

github-actions bot commented Jun 4, 2024

✅ Gradle check result for a9ff2bf: SUCCESS

@reta
Copy link
Collaborator

reta commented Jun 4, 2024

@prudhvigodithi apologies, may I ask you for approve + force merge here, the change backports check-result check (but it is being awaited for since it is not in the workflows), thank you

@prudhvigodithi
Copy link
Contributor

Thanks @reta I understand for check-result, @peternied do yo know why this Minimum approval count is not triggered?

@reta
Copy link
Collaborator

reta commented Jun 4, 2024

@peternied do yo know why this Minimum approval count is not triggered?

@prudhvigodithi it is triggered, the pull request was rebased and needs reapproval, you could approve it (or any other maintainer), I pinged you since forced merge is needed anyway ;-)

@prudhvigodithi prudhvigodithi merged commit 3d0d624 into 2.14 Jun 4, 2024
26 checks passed
@github-actions github-actions bot deleted the backport/backport-13498-to-2.14 branch June 4, 2024 21:29
@peternied
Copy link
Member

do yo know why this Minimum approval count is not triggered?

@prudhvigodithi Yes the way GHA checks are triggered can come from several sources, most often we see pull_request as the trigger source, but for the minimum approver count this comes from contributors / maintainers submitting a 'review' on the change [1] which includes a comment/approval/request changes state. If there is no review on the latest version of the change to merge the check will wait.

The user experience could be improved by using an App which depends on external infrastructure and we just saw how that turned out :doh:

@prudhvigodithi
Copy link
Contributor

I mean the Minimum approval count is already stratified, but expected for an approval again since there was a force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants