Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Remote Routing Table] Add write flow for remote routing table (#13870) #14160

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

himshikha
Copy link
Contributor

@himshikha himshikha commented Jun 11, 2024

Description

Backport for PR #13870

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…earch-project#13870)

* Introduce RemoteRoutingTableService for shard routing table management

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Co-authored-by: Arpit Bandejiya <[email protected]>
Copy link
Contributor

❌ Gradle check result for 8b36f07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Himshikha Gupta added 2 commits June 11, 2024 12:38
Signed-off-by: Himshikha Gupta <[email protected]>
Signed-off-by: Himshikha Gupta <[email protected]>
Copy link
Contributor

❌ Gradle check result for fc4770c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f2a1ddd: SUCCESS

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 81.65138% with 40 lines in your changes missing coverage. Please review.

Project coverage is 71.44%. Comparing base (0dd892c) to head (f2a1ddd).
Report is 341 commits behind head on 2.x.

Files Patch % Lines
...ting/remote/InternalRemoteRoutingTableService.java 84.78% 12 Missing and 2 partials ⚠️
...ensearch/index/remote/RemoteStorePathStrategy.java 69.44% 11 Missing ⚠️
...arch/gateway/remote/RemoteClusterStateService.java 85.71% 4 Missing and 1 partial ⚠️
...ster/routing/remote/RemoteRoutingTableService.java 40.00% 3 Missing ⚠️
...java/org/opensearch/common/blobstore/BlobPath.java 60.00% 1 Missing and 1 partial ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 88.23% 0 Missing and 2 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 0.00% 0 Missing and 1 partial ⚠️
.../routing/remote/NoopRemoteRoutingTableService.java 87.50% 1 Missing ⚠️
...uting/remote/RemoteRoutingTableServiceFactory.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14160      +/-   ##
============================================
+ Coverage     71.28%   71.44%   +0.16%     
- Complexity    60145    61864    +1719     
============================================
  Files          4957     5074     +117     
  Lines        282799   290566    +7767     
  Branches      41409    42348     +939     
============================================
+ Hits         201591   207606    +6015     
- Misses        64189    65489    +1300     
- Partials      17019    17471     +452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 0dcb617 into opensearch-project:2.x Jun 11, 2024
31 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…g table (opensearch-project#13870) (opensearch-project#14160)

* [Remote Routing Table] Add write flow for remote routing table (opensearch-project#13870)

* Introduce RemoteRoutingTableService for shard routing table management

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Co-authored-by: Arpit Bandejiya <[email protected]>
Signed-off-by: kkewwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants