Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make the class CommunityIdProcessor final (#14448) #14453

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

gaobinlong
Copy link
Collaborator

Description

Backport #14448 to 2.x branch.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Make the class CommunityIdProcessor final

Signed-off-by: Gao Binlong <[email protected]>

* Update change log

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Copy link
Contributor

❌ Gradle check result for 6f3c88f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6f3c88f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 6f3c88f: SUCCESS

Copy link
Contributor

❌ Gradle check result for f773405: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f773405: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f773405: SUCCESS

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (0dd892c) to head (f773405).
Report is 394 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14453      +/-   ##
============================================
+ Coverage     71.28%   71.43%   +0.14%     
- Complexity    60145    62241    +2096     
============================================
  Files          4957     5095     +138     
  Lines        282799   292635    +9836     
  Branches      41409    42656    +1247     
============================================
+ Hits         201591   209030    +7439     
- Misses        64189    66025    +1836     
- Partials      17019    17580     +561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants