[Metadata Immutability] Change different indices lookup objects from array type to lists #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolarkunnu
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
Cluster Manager
enhancement
Closed
9 tasks
|
❕ Gradle check result for 4dc93d9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14723 +/- ##
============================================
+ Coverage 71.85% 72.32% +0.46%
- Complexity 64210 64572 +362
============================================
Files 5272 5272
Lines 300538 300530 -8
Branches 43432 43432
============================================
+ Hits 215956 217347 +1391
+ Misses 66884 65664 -1220
+ Partials 17698 17519 -179 ☔ View full report in Codecov by Sentry. |
vikasvb90
reviewed
Jul 14, 2024
|
Thanks @akolarkunnu, changes look good to me! Note for maintainers - discussion on introducing breaking changes and introducing non-breaking changes separately for 2.x was discussed in #14557 |
|
@akolarkunnu Thanks for addressing the comments above. Looking at the concerns/comments regarding added regression, I suggest that you do a small benchmarking exercise to establish if we are actually improving this and not regressing it. It will also give us confidence regarding the changes that we are pushing and also help quantify the improvements (if any). I did something similar as part of #7853
While running your above alias script - you can run |
6 tasks
|
{"run-benchmark-test": "id_9"} |
akolarkunnu
requested review from
gaobinlong,
jed326,
peternied,
jainankitk and
linuxpi
as code owners
akolarkunnu
force-pushed
the
metadata2
branch
from
b6b3d20
to
19aedcd
Compare
|
❌ Gradle check result for b6b3d20: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…array type to lists Changed the arrays to immutable List instances, added new versions of the getters which returns List instances. Resolves opensearch-project#8647 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
|
❕ Gradle check result for d2289d2: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❕ Gradle check result for d2289d2: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
not sure why the benchmark approval didn't run. running again. |
|
{"run-benchmark-test": "id_9"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/856/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/856/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/18/
|
This was referenced Sep 11, 2024
sandeshkr419
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
The performance testing as per https:/opensearch-project/OpenSearch/pull/14723/files#r1752147549 gives confidence that we are not introducing any regression. Also, we avoid back and forth changes with lists/sets now. Changes look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the arrays to immutable List instances, added new versions of the getters which returns List instances.
Related Issues
Resolves #8647
Signed-off-by: Abdul Muneer Kolarkunnu [[email protected]]
Check List
New functionality has been documented.API changes companion pull request created.Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.