Update setting API honors cluster's replica setting as default #14810

[chishui]

Description

This is a fix to #14810.
When user calls

PUT index/_settings
{
  "index": {
    "number_of_replicas": null
  }
}

Previous logic is always set index.number_of_replicas to 1. This PR changes the default value to the one configured by cluster setting cluster.default_number_of_replicas and if it's not configured, a same default 1 will be used. It's consistent to the default replica value when creating an index.

Related Issues

#14810

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❕ Gradle check result for f9e019f: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❕ Gradle check result for a7d986e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (691f725) to head (85662ae).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...luster/metadata/MetadataUpdateSettingsService.java	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14948      +/-   ##
============================================
- Coverage     72.06%   71.98%   -0.08%     
+ Complexity    64822    64786      -36     
============================================
  Files          5308     5308              
  Lines        302574   302556      -18     
  Branches      43710    43709       -1     
============================================
- Hits         218048   217807     -241     
- Misses        66648    66900     +252     
+ Partials      17878    17849      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for b690c89:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for e16d52f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 21e4a19: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[chishui]

❌ Gradle check result for 21e4a19: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#16015

[github-actions]

❕ Gradle check result for 9286a1b: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[chishui]

This change looks good to me, please resolve the conflicts and make sure all gradle checks pass, thanks!

@gaobinlong I resolved conflict and all gradle checks passed

[gaobinlong]

@chishui could you open a documentation PR about this behavior in this repo? Maybe add it here: dynamic-index-level-index-settings, and we even don't have some documentation about the cluster level setting cluster.default_number_of_replicas, could you also help to add it here: cluster-settings.

[gaobinlong]

@reta @andrross @dblock mind taking a second look at this PR?

[gaobinlong]

@chishui could you resolve the conflicts again so that we can get this PR merged? Thanks!

[dbwiddis]

@gaobinlong as maintainers we can also commit to PRs and the conflict was just the changelog so I resolved it in the GitHub UI. Should be mergeable once CI finishes.

[github-actions]

✅ Gradle check result for 85662ae: SUCCESS

[reta]

@reta @andrross @dblock mind taking a second look at this PR?

Sincere apologies, I have missed that, looking

[reta]

Thank you @chishui !

[chishui]

Thank you @gaobinlong @dbwiddis @reta, I'll create a PR for doc updating later.

[dbwiddis]

Thank you @gaobinlong @dbwiddis @reta, I'll create a PR for doc updating later.

You can create an issue now, so the doc team is aware and can plan PR review workload. :)