Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test : Don't use async repo for SplitIndex and wait for translo… #15107

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Aug 5, 2024

…g file deletion

Description

  1. Use sync repo for RemoteSplitIndex IT
  2. Wait for file deletion for remote store cases as it is an async flow .

Related Issues

Resolves #14296

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run Storage Issues and PRs relating to data and metadata storage Storage:Remote labels Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

❌ Gradle check result for ec13798: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna added skip-changelog and removed >test-failure Test failure from CI, local build, etc. flaky-test Random test failure that succeeds on second run autocut Storage Issues and PRs relating to data and metadata storage Storage:Remote labels Aug 5, 2024
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. autocut flaky-test Random test failure that succeeds on second run Storage Issues and PRs relating to data and metadata storage Storage:Remote labels Aug 6, 2024
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

✅ Gradle check result for d02fc4d: SUCCESS

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (48634bd) to head (27935b1).
Report is 19 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15107      +/-   ##
============================================
+ Coverage     71.82%   71.87%   +0.04%     
- Complexity    62778    62829      +51     
============================================
  Files          5169     5169              
  Lines        294646   294665      +19     
  Branches      42610    42616       +6     
============================================
+ Hits         211644   211801     +157     
+ Misses        65573    65453     -120     
+ Partials      17429    17411      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna marked this pull request as ready for review August 6, 2024 06:04
Copy link
Contributor

github-actions bot commented Aug 7, 2024

✅ Gradle check result for 27935b1: SUCCESS

@linuxpi linuxpi merged commit 875b603 into opensearch-project:main Aug 9, 2024
34 of 36 checks passed
@gbbafna gbbafna deleted the split-flaky branch August 9, 2024 12:06
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15107-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 875b603ccead43b5302195c71208e758af1848c2
# Push it to GitHub
git push --set-upstream origin backport/backport-15107-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15107-to-2.x.

gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Aug 10, 2024
opensearch-project#15107)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
gbbafna added a commit to gbbafna/OpenSearch that referenced this pull request Aug 10, 2024
opensearch-project#15107)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
linuxpi pushed a commit that referenced this pull request Aug 10, 2024
#15107) (#15200)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
opensearch-project#15107)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
opensearch-project#15107)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
opensearch-project#15107)

* Flaky test : Don't use async repo for SplitIndex and wait for translog file deletion

Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut backport 2.x Backport to 2.x branch backport-failed flaky-test Random test failure that succeeds on second run skip-changelog Storage:Remote Storage Issues and PRs relating to data and metadata storage >test-failure Test failure from CI, local build, etc.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for RemoteSplitIndexIT
3 participants