Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix null values indexed as "null" strings in flat_object field #15515

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[Backport 2.x] Fix null values indexed as "null" strings in flat_object field #15515

merged 1 commit into from
Aug 30, 2024
+716 −26

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9194b7a from #14069.

@github-actions
Fix null values when indexing in flat_object field (#14069)
1f17544 
Signed-off-by: kkewwei <[email protected]>
(cherry picked from commit 9194b7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1f17544: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 1f17544: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (3c9e08b) to head (1f17544).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ch/common/xcontent/JsonToStringXContentParser.java 60.60% 6 Missing and 7 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15515      +/-   ##
============================================
- Coverage     71.60%   71.55%   -0.05%     
+ Complexity    63549    63493      -56     
============================================
  Files          5222     5222              
  Lines        297639   297660      +21     
  Branches      43325    43331       +6     
============================================
- Hits         213112   212992     -120     
- Misses        66754    66806      +52     
- Partials      17773    17862      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit dcd21c0 into 2.x Aug 30, 2024
57 of 58 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 10, 2024
Open
@andrross andrross deleted the backport/backport-14069-to-2.x branch October 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msfroh