Retry remote state download while bootstrap #15950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosinha
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 3e02411: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sooraj Sinha <[email protected]>
soosinha
force-pushed
the
retry_bootstrap
branch
from
3e02411
to
8f79550
Compare
|
❕ Gradle check result for 8f79550: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15950 +/- ##
============================================
- Coverage 71.90% 71.68% -0.23%
+ Complexity 64216 64112 -104
============================================
Files 5272 5277 +5
Lines 300597 300708 +111
Branches 43440 43451 +11
============================================
- Hits 216151 215567 -584
- Misses 66680 67385 +705
+ Partials 17766 17756 -10 ☔ View full report in Codecov by Sentry. |
server/src/main/java/org/opensearch/gateway/GatewayMetaState.java
Outdated
Show resolved
Hide resolved
...rc/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreClusterStateRestoreIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sooraj Sinha <[email protected]>
shwetathareja
approved these changes
Sep 25, 2024
shwetathareja
merged commit 12dadcf
into
opensearch-project:main
37 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Retry remote state download while bootstrap Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit 12dadcf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 24, 2024
shwetathareja
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Retry remote state download while bootstrap (cherry picked from commit 12dadcf) Signed-off-by: Sooraj Sinha <[email protected]>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
* Retry remote state download while bootstrap Signed-off-by: Sooraj Sinha <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
* Retry remote state download while bootstrap Signed-off-by: Sooraj Sinha <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
* Retry remote state download while bootstrap Signed-off-by: Sooraj Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a remote state enabled cluster manager node boots-up, it tries to download the remote state. But if there some issue while downloading like file not present then the download fails with an exception. The OpenSearch process stays active but unresponsive. This PR addresses this by:
Errorso that process exists and a new process is spawned.Related Issues
NA
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.