Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote publication checksum stats #15957

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

himshikha
Copy link
Contributor

@himshikha himshikha commented Sep 17, 2024

Description

Adding failure stats for checksum validation failure during remote state download.

"remote_full_download" : {
            "success_count" : 1,
            "failed_count" : 0,
            "total_time_in_millis" : 4,
            "checksum_validation_failed_count" : 0
          },
          "remote_diff_download" : {
            "success_count" : 2,
            "failed_count" : 0,
            "total_time_in_millis" : 9,
            "checksum_validation_failed_count" : 0
          }

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Himshikha Gupta <[email protected]>
@Arpit-Bandejiya Arpit-Bandejiya added the backport 2.x Backport to 2.x branch label Sep 17, 2024
@Arpit-Bandejiya
Copy link
Contributor

Can we add happy scenario IT in RemotePublicationIT?

Signed-off-by: Himshikha Gupta <[email protected]>
@himshikha
Copy link
Contributor Author

Can we add happy scenario IT in RemotePublicationIT?

Added

Copy link
Contributor

❌ Gradle check result for babdc2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 94f377e: SUCCESS

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.83%. Comparing base (c709400) to head (94f377e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15957      +/-   ##
============================================
- Coverage     71.93%   71.83%   -0.11%     
+ Complexity    64374    64308      -66     
============================================
  Files          5277     5278       +1     
  Lines        300828   300844      +16     
  Branches      43474    43475       +1     
============================================
- Hits         216411   216118     -293     
- Misses        66725    66943     +218     
- Partials      17692    17783      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 81288b1 into opensearch-project:main Sep 17, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 17, 2024
* Remote publication checksum stats

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 81288b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Bukhtawar pushed a commit that referenced this pull request Sep 19, 2024
* Remote publication checksum stats

Signed-off-by: Himshikha Gupta <[email protected]>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024
* Remote publication checksum stats

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Himshikha Gupta <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
* Remote publication checksum stats

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Himshikha Gupta <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
* Remote publication checksum stats

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Himshikha Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants