Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search_as_you_type not supporting multi-fields #15988

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Fix search_as_you_type not supporting multi-fields #15988

merged 7 commits into from
Sep 23, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Sep 19, 2024 •
edited
Loading

Description

Now search_as_you_type ignores the fields parameter specified in the mapping, the reason is that SearchAsYouTypeFieldMapper doesn't resolve that parameter, this PR fixes the bug.

Related Issues

#5035

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Modify change log
087bf27 
Signed-off-by: Gao Binlong <[email protected]>
@gaobinlong gaobinlong added the backport 2.x Backport to 2.x branch label Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 46195e5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 087bf27: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Fix test failure
605d96d 
Signed-off-by: Gao Binlong <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 605d96d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 605d96d: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for b98cda7: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

This was referenced Sep 20, 2024
Open
Open
@gaobinlong
merge main
c4c8fb1 
Signed-off-by: Gao Binlong <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c4c8fb1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 21, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c4c8fb1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 21, 2024
Closed
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7658bb4: SUCCESS

@gaobinlong
Add more yaml test
ba5a497 
Signed-off-by: Gao Binlong <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ba5a497: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for ba5a497: SUCCESS

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 23, 2024
Closed
@reta reta added bug Something isn't working v3.0.0 Issues and PRs related to version 3.0.0 v2.18.0 Issues and PRs related to version 2.18.0 labels Sep 23, 2024
@reta reta merged commit c85ee68 into opensearch-project:main Sep 23, 2024
48 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@github-actions
Fix search_as_you_type not supporting multi-fields (#15988)
56cca65 
* Fix search_as_you_type not supporting multi-fields

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Fix test failure

Signed-off-by: Gao Binlong <[email protected]>

* Add more yaml test

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit c85ee68)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 23, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 24, 2024
Open
reta added a commit that referenced this pull request Sep 24, 2024
@opensearch-trigger-bot @github-actions @reta
[Backport 2.x] Fix search_as_you_type not supporting multi-fields (#1…
a12e3e6 
…6051)

* Fix search_as_you_type not supporting multi-fields (#15988)

* Fix search_as_you_type not supporting multi-fields

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Fix test failure

Signed-off-by: Gao Binlong <[email protected]>

* Add more yaml test

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
(cherry picked from commit c85ee68)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update 390_search_as_you_type.yml

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Oct 4, 2024
@gaobinlong @ruai0511
Fix search_as_you_type not supporting multi-fields (opensearch-projec…
62518e3 
…t#15988)

* Fix search_as_you_type not supporting multi-fields

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Fix test failure

Signed-off-by: Gao Binlong <[email protected]>

* Add more yaml test

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@gaobinlong @dk2k
Fix search_as_you_type not supporting multi-fields (opensearch-projec…
49adce3 
…t#15988)

* Fix search_as_you_type not supporting multi-fields

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Fix test failure

Signed-off-by: Gao Binlong <[email protected]>

* Add more yaml test

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@gaobinlong @dk2k
Fix search_as_you_type not supporting multi-fields (opensearch-projec…
adb0c85 
…t#15988)

* Fix search_as_you_type not supporting multi-fields

Signed-off-by: Gao Binlong <[email protected]>

* Modify change log

Signed-off-by: Gao Binlong <[email protected]>

* Fix test failure

Signed-off-by: Gao Binlong <[email protected]>

* Add more yaml test

Signed-off-by: Gao Binlong <[email protected]>

---------

Signed-off-by: Gao Binlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jed326 jed326 Awaiting requested review from jed326

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working v2.18.0 Issues and PRs related to version 2.18.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaobinlong @reta