Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coordinator search.request_stats_enabled by default #16290

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Oct 11, 2024

Description

Enable coordinator search.request_stats_enabled by default

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dzane17 dzane17 added the backport 2.x Backport to 2.x branch label Oct 11, 2024
Copy link
Contributor

❌ Gradle check result for ffaed5a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 8a802a1: SUCCESS

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (691f725) to head (8a802a1).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16290      +/-   ##
============================================
- Coverage     72.06%   71.93%   -0.13%     
+ Complexity    64822    64734      -88     
============================================
  Files          5308     5307       -1     
  Lines        302574   302540      -34     
  Branches      43710    43708       -2     
============================================
- Hits         218048   217643     -405     
- Misses        66648    66999     +351     
- Partials      17878    17898      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member

@dzane17 does this need any documentation updates (see checklist in first comment)

@dzane17
Copy link
Contributor Author

dzane17 commented Oct 14, 2024

@dbwiddis I checked the nodes stats API documentation. We don't specify default values so no doc PR is needed. https://opensearch.org/docs/latest/api-reference/nodes-apis/nodes-stats/

@dbwiddis dbwiddis merged commit 88d13eb into opensearch-project:main Oct 14, 2024
42 of 43 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88d13eb5bd3bbea3a04b7b0c7576ca00d0f8435c
# Push it to GitHub
git push --set-upstream origin backport/backport-16290-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16290-to-2.x.

@dbwiddis
Copy link
Member

@dzane17 can you please do a manual backport?

@dzane17 dzane17 deleted the nodes-stats branch October 14, 2024 20:41
dzane17 added a commit to dzane17/OpenSearch that referenced this pull request Oct 14, 2024
…h-project#16290)

Signed-off-by: David Zane <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
(cherry picked from commit 88d13eb)
jainankitk pushed a commit that referenced this pull request Oct 14, 2024
…16320)

Signed-off-by: David Zane <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
(cherry picked from commit 88d13eb)
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants