Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode #16299

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode #16299

merged 2 commits into from
Oct 14, 2024
+35 −10

Conversation

imRishN
Copy link
Member

@imRishN imRishN commented Oct 13, 2024 •
edited
Loading

Description

Skip unnecessary string format in RemoteStoreMigrationAllocationDecider when not in debug mode

Related Issues

Master hot thread -

app//org.opensearch.cluster.routing.allocation.decider.RemoteStoreMigrationAllocationDecider.getDecisionDetails(RemoteStoreMigrationAllocationDecider.java:196)
       app//org.opensearch.cluster.routing.allocation.decider.RemoteStoreMigrationAllocationDecider.canAllocate(RemoteStoreMigrationAllocationDecider.java:94)
       app//org.opensearch.cluster.routing.allocation.decider.AllocationDeciders.canAllocate(AllocationDeciders.java:94)
       app//org.opensearch.cluster.routing.allocation.allocator.LocalShardsBalancer.decideAllocateUnassigned(LocalShardsBalancer.java:980)
       app//org.opensearch.cluster.routing.allocation.allocator.LocalShardsBalancer.allocateUnassigned(LocalShardsBalancer.java:866)
       app//org.opensearch.cluster.routing.allocation.allocator.BalancedShardsAllocator.allocate(BalancedShardsAllocator.java:353)
       app//org.opensearch.cluster.routing.allocation.AllocationService.reroute(AllocationService.java:575)
       app//org.opensearch.cluster.routing.allocation.AllocationService.reroute(AllocationService.java:542)
       app//org.opensearch.cluster.routing.allocation.AllocationService.disassociateDeadNodes(AllocationService.java:353)
       app//org.opensearch.cluster.coordination.NodeRemovalClusterStateTaskExecutor.getTaskClusterTasksResult(NodeRemovalClusterStateTaskExecutor.java:123)
       app//org.opensearch.cluster.coordination.NodeRemovalClusterStateTaskExecutor.execute(NodeRemovalClusterStateTaskExecutor.java:113)
       app//org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:912)
       app//org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:464)
       app//org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:324)
       app//org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:228)
       app//org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:215)
       app//org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:257)
       app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:891)

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@imRishN
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
60c167c 
…er when not in debug mode

Signed-off-by: Rishab Nahata <[email protected]>
Bukhtawar
Bukhtawar reviewed Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @gbbafna @shourya035 for help with review

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 60c167c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@imRishN
Fix
13627a0 
Signed-off-by: Rishab Nahata <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 13627a0: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (20536ee) to head (13627a0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...decider/RemoteStoreMigrationAllocationDecider.java 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16299      +/-   ##
============================================
+ Coverage     72.00%   72.06%   +0.05%     
- Complexity    64796    64846      +50     
============================================
  Files          5307     5307              
  Lines        302540   302543       +3     
  Branches      43708    43708              
============================================
+ Hits         217853   218021     +168     
+ Misses        66801    66634     -167     
- Partials      17886    17888       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dbwiddis
dbwiddis approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit.

...org/opensearch/cluster/routing/allocation/decider/RemoteStoreMigrationAllocationDecider.java Show resolved Hide resolved
@gbbafna gbbafna merged commit 5d2d392 into opensearch-project:main Oct 14, 2024
42 of 43 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 14, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 14, 2024
@github-actions
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
c0a634b 
…er when not in debug mode (#16299)

Signed-off-by: Rishab Nahata <[email protected]>
(cherry picked from commit 5d2d392)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 14, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 12, 2024
Open
dbwiddis pushed a commit that referenced this pull request Oct 14, 2024
@opensearch-trigger-bot @github-actions
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
4ba1f4f 
…er when not in debug mode (#16299) (#16301)

(cherry picked from commit 5d2d392)

Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@imRishN @dk2k
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
665daa8 
…er when not in debug mode (opensearch-project#16299)

Signed-off-by: Rishab Nahata <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@imRishN @dk2k
Skip unnecessary string format in RemoteStoreMigrationAllocationDecid…
43505c9 
…er when not in debug mode (opensearch-project#16299)

Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar left review comments

@gbbafna gbbafna gbbafna approved these changes

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imRishN @dbwiddis @Bukhtawar @gbbafna