Approximate match all with sort with a bounded range query #16321
+428
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
{"run-benchmark-test": "id_5"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1339/ . Final results will be published once the job is completed. |
3 tasks
|
❌ Gradle check result for b7d1af0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
force-pushed
the
approximate_MatchAllQuery
branch
from
b7d1af0
to
0613b64
Compare
|
❌ Gradle check result for 0613b64: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
force-pushed
the
approximate_MatchAllQuery
branch
from
0613b64
to
2bf0e80
Compare
|
❌ Gradle check result for 2bf0e80: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
{"run-benchmark-test": "id_14"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1340/ . Final results will be published once the job is completed. |
|
The benchmark job https://build.ci.opensearch.org/job/benchmark-pull-request/1340/ failed. |
The feature flag was never added to ALL_FEATURE_FLAG_SETTINGS. |
|
{"run-benchmark-test": "id_14"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1341/ . Final results will be published once the job is completed. |
|
The benchmark job https://build.ci.opensearch.org/job/benchmark-pull-request/1341/ failed. |
|
❌ Gradle check result for 914801f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 914801f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
msfroh
force-pushed
the
approximate_MatchAllQuery
branch
from
914801f
to
b480ed9
Compare
|
❕ Gradle check result for b480ed9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16321 +/- ##
=========================================
Coverage 71.96% 71.96%
- Complexity 64791 64838 +47
=========================================
Files 5307 5308 +1
Lines 302714 302734 +20
Branches 43733 43735 +2
=========================================
+ Hits 217836 217858 +22
+ Misses 67013 66986 -27
- Partials 17865 17890 +25 ☔ View full report in Codecov by Sentry. |
|
{"run-benchmark-test": "id_14"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1356/ . Final results will be published once the job is completed. |
msfroh
force-pushed
the
approximate_MatchAllQuery
branch
from
b480ed9
to
354f396
Compare
|
{"run-benchmark-test": "id_14"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1357/ . Final results will be published once the job is completed. |
msfroh
requested review from
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
|
{"run-benchmark-test": "id_14"} Kicking off another benchmark, now that I disabled the optimization for scroll queries (since it doesn't work with scroll queries). At this point, I'm a little worried that I'm just seeing speedups when I break things. The things I'm actually trying to speed up aren't much better in the previous benchmark run. |
|
Invalid comment format or config id. Please refer to https:/opensearch-project/OpenSearch/blob/main/PERFORMANCE_BENCHMARKS.md on how to run benchmarks on pull requests. |
|
{"run-benchmark-test": "id_14"} |
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1387/ . Final results will be published once the job is completed. |
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/1387/
|
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/21/
|
|
Hmm... the scroll performance is still unbelievably better, which shouldn't have happened with my latest changes. Again, this shortcut would break scrolls if applied. Also, it made the I need to spend some time debugging to see why a) |
|
@rishabh6788 -- can you please clarify what "baseline" is in this context? In theory, the |
The baseline runs are nightly benchmarks running on latest minimum snapshot build of mainline without any feature flags. Let me know if you need help with debugging this locally, I can provide you with the same exact data and settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we run a match-all query and sort results by a numeric/timestamp field, then we can replace the match-all with a filter over the top/bottom 10,000 (or whatever
track_total_hitsis set to) values from the sort field.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.