Skip media type parsing for known string values

[andrross]

Less intrusive optimization solving the same problem as #16073

Related Issues

Resolves #15979

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for cae2f71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dblock]

Any reason not to forward optimize and add the result of parseMediaType to this map?

[reta]

Love it @andrross ! Thank you!

Any reason not to forward optimize and add the result of parseMediaType to this map?

@dblock I think it would complicate things a lot:
a) map is immutable now but it won't be anymore (with all the consequences)
b) map has to be capped since parseMediaType could accept myriad of variations

I believe the parseMediaType will be done only once for a whole request, may be it is an acceptable tradeoff?

[reta]

LGTM to me!

[andrross]

Any reason not to forward optimize and add the result of parseMediaType to this map?

@dblock I think it would complicate things a lot:
a) map is immutable now but it won't be anymore (with all the consequences)
b) map has to be capped since parseMediaType could accept myriad of variations

@dblock I agree with @reta about the complexities. Also, in my simple testing I can't even find the Content-Type header parsing anywhere in the profile so I think it is negligible. This optimization is targeted at the transport protocol where we've already got a MediaType instance and we just want to serialize it across the wire in the binary protocol.

[github-actions]

✅ Gradle check result for cae2f71: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (ec7b652) to head (cae2f71).
Report is 5 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16358      +/-   ##
============================================
+ Coverage     72.00%   72.03%   +0.02%     
- Complexity    64817    64838      +21     
============================================
  Files          5307     5307              
  Lines        302660   302670      +10     
  Branches      43724    43725       +1     
============================================
+ Hits         217931   218022      +91     
+ Misses        66906    66746     -160     
- Partials      17823    17902      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.