Treat last fetch timestamp of pinned timestamp as one of the pinned timestamps #16392
+165
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metadata 2
but Metadata 1 will be deleted creating data loss issues forSnapshot 1
andSnapshot 2
.So, we need to fix Scenario 2. In this scenario, we need to keep the last metadata file before the pin timestamp fetch. Only keeping last md file is sufficient as any snapshot that is created will only refer to the last md file.
In this PR, we add last fetch timestamp to the pinned timestamp list to avoid deletion of last metadata file created prior to last fetch.
With change in this PR, we don't need changes done in Bugfix in snapshot V2 restore flow #16332 to always keep last deleted file. This improves stale data deletion as well.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.