Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Adding extension framework support for first extension point #3107

Merged
merged 14 commits into from
Apr 29, 2022
Merged

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Apr 29, 2022

Description

Adding support for first example extension point and some refactoring.
This change is for feature/extensions branch.

Issues

#2711
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

saratvemulapalli and others added 11 commits April 29, 2022 09:27
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 71bc4df
Log 4865

Reports 4865

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0384f2f
Log 4866

Reports 4866

Signed-off-by: Sarat Vemulapalli <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 45827f0
Log 4867

Reports 4867

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Added few nitpicks

Signed-off-by: Sarat Vemulapalli <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9baf0df
Log 4869

Reports 4869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants