Add index level setting for remote store #3243
Conversation
|
What if someone wants remote store setting to be true for all indices by default. Can the default value be behind a setting too? |
In that case, user needs to provide the setting with true value while creating each index. IMO, |
|
✅ Gradle Check success bb259ec8083377b2fc5a66ce2dfd59d87451bb3a |
| public static final String SETTING_REMOTE_STORE = "index.remote_store"; | ||
| /** | ||
| * Used to specify if the index data should be persisted in the remote store. | ||
| */ | ||
| public static final Setting<Boolean> INDEX_REMOTE_STORE_SETTING = Setting.boolSetting( | ||
| SETTING_REMOTE_STORE, | ||
| false, | ||
| Property.IndexScope, | ||
| Property.Final | ||
| ); |
There was a problem hiding this comment.
Wondering if we should have separate controls for remote segment store and remote translog store
There was a problem hiding this comment.
Agree, we may need to provide a granular control. Once we finalize these settings, we can either add them or split this one. Let me add it as an issue in the Meta Issue.
There was a problem hiding this comment.
Or I will keep updating the parent issue of this PR: #3141.
There was a problem hiding this comment.
Let's put this behind an opensearch.experimental.feature.remote_store.enabled feature flag that was introduced in #3037
nknize
added
feature
Signed-off-by: Sachin Kale <[email protected]>
sachinpkale
force-pushed
the
feature/durability-enhancements
branch
from
bb259ec
to
8b6bdfa
Compare
Bukhtawar
merged commit bcfd328
into
opensearch-project:feature/durability-enhancements
Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale [email protected]
Description
As explained in V1 of remote store, uploading translog and segments to remote store will be at index level and the setting can be provided while creating the index. This change adds a final index level setting.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.