Deprecate and rename abstract methods in interfaces that contain 'master' in name #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xue Zhou <[email protected]>
tlfeng
changed the title
tlfeng
added
enhancement
tlfeng
approved these changes
Aug 3, 2022
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4121 +/- ##
============================================
+ Coverage 70.61% 70.72% +0.11%
- Complexity 56983 57058 +75
============================================
Files 4595 4597 +2
Lines 274234 274240 +6
Branches 40181 40181
============================================
+ Hits 193638 193946 +308
+ Misses 64342 64016 -326
- Partials 16254 16278 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
…ter' in name (#4121) Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit ba9cdcd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
…ter' in name (#4121) Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit ba9cdcd)
This was referenced Aug 4, 2022
tlfeng
pushed a commit
that referenced
this pull request
Aug 4, 2022
…ter' in name (#4121) (#4123) Deprecate and rename abstract methods in interface ``` - in interface LocalNodeMasterListener: void onMaster() void offMaster() - in interface AckedRequest: TimeValue masterNodeTimeout() ``` Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit ba9cdcd)
xuezhou25
added a commit
that referenced
this pull request
Aug 4, 2022
…ter' in name (#4121) (#4122) Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit ba9cdcd) Co-authored-by: Xue Zhou <[email protected]>
xuezhou25
deleted the
rename_and_deprecate_abstract_methods_in_interface_LocalNodeMasterListener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xue Zhou [email protected]
Description
Deprecate and rename abstract methods in interface
Issues Resolved
#3544
#3543
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.