Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NodeGatewayStartedShards bwc (de)serialization issues #4258

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 18, 2022

Signed-off-by: Andriy Redko [email protected]

Description

The bwc (de)serialization issue has been introduced by [1], breaking the main builds (fe [2])

[1] #4252
[2] https://build.ci.opensearch.org/job/gradle-check/1896/testReport/junit/org.opensearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_indices_open_20_multiple_indices_Only_wildcard_/

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner August 18, 2022 19:22
@reta reta added >test-failure Test failure from CI, local build, etc. backwards-compatibility labels Aug 18, 2022
@reta
Copy link
Collaborator Author

reta commented Aug 18, 2022

@dreamer-89 fyi

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reta for fixing this.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit ee26e01 into opensearch-project:main Aug 18, 2022
dbwiddis pushed a commit to dbwiddis/OpenSearch that referenced this pull request Aug 19, 2022
dbwiddis pushed a commit to dbwiddis/OpenSearch that referenced this pull request Aug 19, 2022
owaiskazi19 pushed a commit that referenced this pull request Aug 19, 2022
* Provide Extension API to OpenSearch

Signed-off-by: Daniel Widdis <[email protected]>

* Add tests

Signed-off-by: Daniel Widdis <[email protected]>

* Add javadocs

Signed-off-by: Daniel Widdis <[email protected]>

* Add parsing of API requests

Signed-off-by: Daniel Widdis <[email protected]>

* Tweak API parsing for more flexible user formatting

Signed-off-by: Daniel Widdis <[email protected]>

* Remove forbidden toUpperCase usage

Signed-off-by: Daniel Widdis <[email protected]>

* Fix failing test as we now register four handlers

Signed-off-by: Daniel Widdis <[email protected]>

* Rename Api to RestApi

Signed-off-by: Daniel Widdis <[email protected]>

* Fix errors in previous merge conflict resolution

Signed-off-by: Daniel Widdis <[email protected]>

* Rename RestApi to RestActions

Signed-off-by: Daniel Widdis <[email protected]>

* Fix tests to fail on the correct wrong thing

Signed-off-by: Daniel Widdis <[email protected]>

* More verbose variable name

Signed-off-by: Daniel Widdis <[email protected]>

* Fix license header

Signed-off-by: Daniel Widdis <[email protected]>

* Fixing NodeGatewayStartedShards bwc (de)serialization issues (#4258)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Fixing NodeGatewayStartedShards bwc (de)serialization issues (#4258)

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>

* Fix tests to account for TotalHits uncertainty

Signed-off-by: Daniel Widdis <[email protected]>

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Co-authored-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants