Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/extensions] Add getSettings support for AD #4519

Merged
merged 14 commits into from
Sep 20, 2022
Merged

[Feature/extensions] Add getSettings support for AD #4519

merged 14 commits into from
Sep 20, 2022

Commits on Sep 17, 2022

  1. Copy and rename RestHandler code for Settings 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    6674f71 View commit details
    Browse the repository at this point in the history

  2. WriteableSetting wrapper class and RegisterSettingsRequest 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    b540fb3 View commit details
    Browse the repository at this point in the history

  3. Actually register the requested settings 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    1148378 View commit details
    Browse the repository at this point in the history

  4. Add Version Setting and all WriteableSettingTests 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    3a8cebf View commit details
    Browse the repository at this point in the history

  5. Add remaining tests 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    15a37d8 View commit details
    Browse the repository at this point in the history

  6. Use compataible setting properties 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    1b03f87 View commit details
    Browse the repository at this point in the history

  7. Change log entry 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    d3e5be2 View commit details
    Browse the repository at this point in the history

  8. Better Enum handling 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    d8101ae View commit details
    Browse the repository at this point in the history

  9. Typo fixes and link to TODO issue 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    f3757b9 View commit details
    Browse the repository at this point in the history

  10. Update the count for merged request handler 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    f7199e4 View commit details
    Browse the repository at this point in the history

  11. Eliminate unnecessary temporary variables 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    67b6d35 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. Shorten inner class name for readability 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    e49411a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Address code review comments 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    806c04d View commit details
    Browse the repository at this point in the history

  2. s/Settings/CustomSettings/g 

    Signed-off-by: Daniel Widdis <[email protected]>
    @dbwiddis
    dbwiddis committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a019a9d View commit details
    Browse the repository at this point in the history