[Feature/extensions] Pass REST params and content to extensions #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4633 +/- ##
=====================================================
Coverage 70.62% 70.63%
- Complexity 57557 57559 +2
=====================================================
Files 4654 4656 +2
Lines 276657 276679 +22
Branches 40427 40429 +2
=====================================================
+ Hits 195399 195434 +35
+ Misses 64967 64918 -49
- Partials 16291 16327 +36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Got it... the PR includes |
peternied
approved these changes
Sep 29, 2022
| * | ||
| * @opensearch.api | ||
| */ | ||
| public class ExtensionRestRequest extends TransportRequest { |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
changed the title
Gradle Check (Jenkins) Run Completed with:
|
|
Ready for review. Gradle check failure is unrelated to this PR. |
Signed-off-by: Daniel Widdis <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
DarshitChanpura
approved these changes
Sep 30, 2022
| public int hashCode() { | ||
| return Objects.hash(method, path, params, xContentType, content, principalIdentifierToken); | ||
| } | ||
| } |
| @@ -105,12 +108,16 @@ public List<Route> routes() { | |||
|
|
|||
| @Override | |||
| public RestChannelConsumer prepareRequest(final RestRequest request, final NodeClient client) throws IOException { | |||
There was a problem hiding this comment.
qq, out of scope of this PR, should we change the method name to handleRequest in TransportRequest.java at some point in future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR on SDK: #163
Description
Passes the
params()from the originalRestRequestobject to extensions. Internally tracks the consumed params (similar to theRestRequestclass) when they are consumed with theparam(key)method (similar to existing plugin usage).During the process, realized that the
RestExecuteOnExtensionRequestclass (here) completely duplicated theExtensionRestHandlerclass (in the SDK), so removed the SDK duplicate and renamed the "Execute" class asExtensionRestHandler.Additionally added xContentType and content as well as getters for the params that will enable AD extension functionality, and handling the consumed content on the response.
Issues Resolved
Fixes #111
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.