Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Add contentParser method to ExtensionRestRequest #4760

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Oct 13, 2022

Signed-off-by: Daniel Widdis [email protected]

Companion PR: opensearch-project/opensearch-sdk-java#192

This PR does not change the API and can be merged at any time before the companion PR even if it is still in review.

Description

Adds a contentParser() method to the ExtensionRestRequest class to enable extensions to parse REST requests with bodies containing JSON, SMILE, YAML, or CBOR.

Issues Resolved

OpenSearch part of SDK #178

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dbwiddis dbwiddis requested review from a team and reta as code owners October 13, 2022 01:56
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4760 (c60eddf) into feature/extensions (dfeefa6) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4760      +/-   ##
========================================================
- Coverage                 70.71%   70.66%   -0.06%     
+ Complexity                57896    57884      -12     
========================================================
  Files                      4706     4706              
  Lines                    277831   277834       +3     
  Branches                  40389    40389              
========================================================
- Hits                     196481   196330     -151     
- Misses                    65114    65250     +136     
- Partials                  16236    16254      +18     
Impacted Files Coverage Δ
...ensearch/extensions/rest/ExtensionRestRequest.java 77.61% <100.00%> (+2.61%) ⬆️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...arch/search/aggregations/pipeline/LinearModel.java 23.07% <0.00%> (-46.16%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...nsearch/discovery/InitializeExtensionsRequest.java 0.00% <0.00%> (-40.00%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
... and 482 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshpalis joshpalis self-requested a review October 13, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants