Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] LegacyESVersion.V_7_6_* and V_7_7_* constants #4837

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 19, 2022

Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version constants along with ancient API logic.

relates #2747

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 19, 2022
@nknize nknize requested review from a team and reta as code owners October 19, 2022 15:03
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 19, 2022

Oh fun! Looks like we have a race condition in IndexShardIT.testIndexCanChangeCustomDataPath.

deleteReaderFiles must be getting called async before the test finishes copying.

[2022-10-19T08:21:35,640][ERROR][o.o.i.s.IndexShardIT     ] [testIndexCanChangeCustomDataPath] Failed to copy data path directory
java.nio.file.NoSuchFileException: /var/jenkins/workspace/gradle-check/search/server/build/testrun/internalClusterTest/temp/org.opensearch.index.shard.IndexShardIT_B9157C425F286EBE-001/rxeTWWtHeW/start-KZvCXclcHt/0/ipMqHwdkRym5TzwG0a3ubg/0/translog/translog-3794781907109570892.ckp

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #4837 (7cd881f) into main (ec34737) will increase coverage by 0.06%.
The diff coverage is 68.32%.

@@             Coverage Diff              @@
##               main    #4837      +/-   ##
============================================
+ Coverage     70.70%   70.77%   +0.06%     
+ Complexity    57852    57842      -10     
============================================
  Files          4689     4689              
  Lines        277080   276866     -214     
  Branches      40302    40219      -83     
============================================
+ Hits         195917   195957      +40     
+ Misses        64935    64765     -170     
+ Partials      16228    16144      -84     
Impacted Files Coverage Δ
...ch/analysis/common/CommonAnalysisModulePlugin.java 92.28% <0.00%> (-1.32%) ⬇️
.../src/main/java/org/opensearch/LegacyESVersion.java 65.00% <ø> (-0.72%) ⬇️
.../node/reload/NodesReloadSecureSettingsRequest.java 18.51% <0.00%> (+0.66%) ⬆️
...ster/snapshots/restore/RestoreSnapshotRequest.java 66.08% <ø> (+3.26%) ⬆️
...tion/admin/cluster/stats/ClusterStatsResponse.java 18.64% <0.00%> (+0.61%) ⬆️
.../src/main/java/org/opensearch/common/Rounding.java 86.72% <ø> (+0.17%) ⬆️
.../main/java/org/opensearch/index/engine/Engine.java 73.82% <ø> (-1.30%) ⬇️
...rg/opensearch/indices/analysis/AnalysisModule.java 94.23% <0.00%> (+2.64%) ⬆️
...ch/repositories/blobstore/BlobStoreRepository.java 64.84% <ø> (+0.85%) ⬆️
.../opensearch/transport/ProxyConnectionStrategy.java 64.06% <0.00%> (-22.97%) ⬇️
... and 520 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Oct 21, 2022

I believe this has been fixed in #4270, rebase?

@nknize nknize force-pushed the remove/7677VersionConstants branch from a317763 to 6bfadbb Compare October 21, 2022 16:43
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Removes all usages of LegacyESVersion.V_7_6_ and LegacyESVersion.V_7_7_ version
constants along with ancient API logic.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize force-pushed the remove/7677VersionConstants branch from 6bfadbb to 1f533a0 Compare November 1, 2022 12:32
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit fab4336 into opensearch-project:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants