[Feature/extensions] Modified local node response #4862

joshpalis · 2022-10-20T21:33:43Z

Description

Added getter method to local node response to return the Discovery Node

Edit : Separate local Node Requests are not necessary to provide support for since the local node is already transported to the SDK during node initialization. Will now use this pull request to remove the local node request workflow from the project

Companion PR : opensearch-project/opensearch-sdk-java#202

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <[email protected]>

github-actions · 2022-10-20T22:05:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5125/
CommitID: 93057fe

github-actions · 2022-10-20T22:13:32Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5127/
CommitID: e75ff6c

owaiskazi19 · 2022-10-20T23:26:06Z

server/src/main/java/org/opensearch/cluster/LocalNodeResponse.java

+ */
+ public DiscoveryNode getLocalNode() {
+ return this.localNode;
+ }


Can we add a small test to verify this getter value?

Sure ill add this in

(Style/entirely personal preference) Would really like this further up in the class than below the equals and hashcode, although others prefer getters and setters at the bottom.

Signed-off-by: Joshua Palis <[email protected]>

github-actions · 2022-10-21T00:41:44Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5134/
CommitID: 2682258

dbwiddis

LGTM with two minor comments!

dbwiddis · 2022-10-21T04:16:23Z

server/src/test/java/org/opensearch/extensions/ExtensionsOrchestratorTests.java

@@ -485,6 +485,22 @@ public void testHandleActionListenerOnFailureRequest() throws Exception {
 assertEquals("Test failure", extensionsOrchestrator.listener.getExceptionList().get(0).getMessage());
 }

+ public void testLocalNodeResponse() throws Exception {


Thanks for adding this test! But I'm thinking it should probably be in the same package as the LocalNodeResponse class (src/test/java/org/opensearch/cluster) as it's not specific to extensions.

dbwiddis · 2022-10-21T04:22:55Z

server/src/main/java/org/opensearch/cluster/LocalNodeResponse.java

+ */
+ public DiscoveryNode getLocalNode() {
+ return this.localNode;
+ }


(Style/entirely personal preference) Would really like this further up in the class than below the equals and hashcode, although others prefer getters and setters at the bottom.

Signed-off-by: Joshua Palis <[email protected]>

github-actions · 2022-10-21T21:12:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5236/
CommitID: 67d0bdc

github-actions · 2022-10-21T21:15:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5238/
CommitID: b03a372

joshpalis · 2022-10-21T22:07:53Z

@dbwiddis Upon further exploration, I realized that the sendLocalNodeRequest is redundant since we already transport the local node to the SDK during extension initialization here. Moving forward, I shall remove the sendLocalNodeRequest workflow from the project and add a getter on the ExtensionRunner in order to provide access to the ExtensionRunner.opensearchNode, which is the local node that we are concerned with.

…al node is already transported to the opensearch SDK during extension intialization Signed-off-by: Joshua Palis <[email protected]>

github-actions · 2022-10-21T22:46:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5282/
CommitID: a68bc99

codecov-commenter · 2022-10-21T22:48:46Z

Codecov Report

Merging #4862 (a41b8f0) into feature/extensions (9ea149e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             feature/extensions    #4862      +/-   ##
========================================================
- Coverage                 70.90%   70.89%   -0.01%     
+ Complexity                58243    58215      -28     
========================================================
  Files                      4734     4733       -1     
  Lines                    278272   278254      -18     
  Branches                  40403    40402       -1     
========================================================
- Hits                     197301   197271      -30     
- Misses                    64692    64708      +16     
+ Partials                  16279    16275       -4

Impacted Files	Coverage Δ
.../opensearch/extensions/ExtensionsOrchestrator.java	`66.66% <ø> (-0.18%)`	⬇️
...n/indices/forcemerge/ForceMergeRequestBuilder.java	`0.00% <0.00%> (-75.00%)`	⬇️
...pensearch/client/cluster/RemoteConnectionInfo.java	`0.00% <0.00%> (-73.18%)`	⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java	`0.00% <0.00%> (-60.00%)`	⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java	`0.00% <0.00%> (-58.83%)`	⬇️
.../java/org/opensearch/node/NodeClosedException.java	`50.00% <0.00%> (-50.00%)`	⬇️
...rch/client/transport/NoNodeAvailableException.java	`28.57% <0.00%> (-42.86%)`	⬇️
.../opensearch/client/cluster/RemoteInfoResponse.java	`61.53% <0.00%> (-38.47%)`	⬇️
...ensearch/client/indices/DetailAnalyzeResponse.java	`20.54% <0.00%> (-34.25%)`	⬇️
...nsearch/index/shard/IndexShardClosedException.java	`66.66% <0.00%> (-33.34%)`	⬇️
... and 490 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Joshua Palis <[email protected]>

github-actions · 2022-10-28T19:15:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5867/
CommitID: cbc2b97

github-actions · 2022-10-28T22:43:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/5890/
CommitID: a41b8f0

joshpalis added 2 commits October 20, 2022 19:40

Added getter for local node response

8274b2d

Signed-off-by: Joshua Palis <[email protected]>

Update changlog

93057fe

Signed-off-by: Joshua Palis <[email protected]>

joshpalis requested review from a team and reta as code owners October 20, 2022 21:33

joshpalis mentioned this pull request Oct 20, 2022

Modified local node request to return discovery node directly to caller opensearch-project/opensearch-sdk-java#202

Merged

Updating changelog

e75ff6c

Signed-off-by: Joshua Palis <[email protected]>

joshpalis self-assigned this Oct 20, 2022

joshpalis requested review from dbwiddis and owaiskazi19 October 20, 2022 21:35

joshpalis changed the title ~~Modified local node request to return discovery node directly to caller~~ [Feature/extensions] Modified local node response Oct 20, 2022

owaiskazi19 approved these changes Oct 20, 2022

View reviewed changes

owaiskazi19 reviewed Oct 20, 2022

View reviewed changes

Adding test for getLocalNode

2682258

Signed-off-by: Joshua Palis <[email protected]>

dbwiddis reviewed Oct 21, 2022

View reviewed changes

joshpalis added 2 commits October 21, 2022 20:39

rebasing with featue/extensions

67d0bdc

Signed-off-by: Joshua Palis <[email protected]>

Moving local node getter to

b03a372

Signed-off-by: Joshua Palis <[email protected]>

Removing local node request / response workflow alltogether since loc…

a68bc99

…al node is already transported to the opensearch SDK during extension intialization Signed-off-by: Joshua Palis <[email protected]>

joshpalis requested review from dbwiddis and owaiskazi19 October 21, 2022 22:33

dbwiddis approved these changes Oct 24, 2022

View reviewed changes

Rebasing with feature/extensions

cbc2b97

Signed-off-by: Joshua Palis <[email protected]>

joshpalis requested a review from vibrantvarun October 28, 2022 18:53

vibrantvarun approved these changes Oct 28, 2022

View reviewed changes

Merge branch 'feature/extensions' into local-node

a41b8f0

owaiskazi19 approved these changes Oct 31, 2022

View reviewed changes

owaiskazi19 merged commit c2ecebd into opensearch-project:feature/extensions Oct 31, 2022

This was referenced Nov 15, 2022

[Feature/extensions] Meta: Merge back to main tracking issue #5263

Closed

[Feature/extensions] Merge to main tracking - REST, TranportActions, and EnvironmentSettings updates (up to present) #5273

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature/extensions] Modified local node response #4862

[Feature/extensions] Modified local node response #4862

joshpalis commented Oct 20, 2022 •

edited

Loading

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

owaiskazi19 Oct 20, 2022

joshpalis Oct 21, 2022

dbwiddis Oct 21, 2022

github-actions bot commented Oct 21, 2022

dbwiddis left a comment

dbwiddis Oct 21, 2022

dbwiddis Oct 21, 2022

github-actions bot commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

joshpalis commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

codecov-commenter commented Oct 21, 2022 •

edited

Loading

github-actions bot commented Oct 28, 2022

github-actions bot commented Oct 28, 2022

[Feature/extensions] Modified local node response #4862

[Feature/extensions] Modified local node response #4862

Conversation

joshpalis commented Oct 20, 2022 • edited Loading

Description

Check List

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

owaiskazi19 Oct 20, 2022

Choose a reason for hiding this comment

joshpalis Oct 21, 2022

Choose a reason for hiding this comment

dbwiddis Oct 21, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

dbwiddis left a comment

Choose a reason for hiding this comment

dbwiddis Oct 21, 2022

Choose a reason for hiding this comment

dbwiddis Oct 21, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

joshpalis commented Oct 21, 2022

github-actions bot commented Oct 21, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Oct 21, 2022 • edited Loading

Codecov Report

github-actions bot commented Oct 28, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 28, 2022

Gradle Check (Jenkins) Run Completed with:

joshpalis commented Oct 20, 2022 •

edited

Loading

codecov-commenter commented Oct 21, 2022 •

edited

Loading