[Backport] [2.x] Add missing no jdk distributions (#4722) #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing no-jdk gradle targets for distributions by convention all supported platforms should also have a gradle target to produce a no-jdk build and that target should be called `no-jdk-[platform]`. this is a first step in the path to publishing the no-jdk distributions as part of the release, as there are use-cases where a specific JDK should be used instead of the packaged one and it's cleaner to use a small distribution which doesn't bring along an unneeded JDK (the JDK greatly increases the resulting distribution since). note that i failed to rename the `linux-s390x` target, it seems that there's too much generic build code out there which tries to stitch together that name and then fails if it doesn't find it. this is part of opensearch-build#99. Signed-off-by: Ralph Ursprung <[email protected]> * add basic README for `:distribution` this is primarily to document the JDK & No JDK setup (to codify it for the future), however the README can be extended in the future to document more information which is currently hidden away only somewhere in the code. Signed-off-by: Ralph Ursprung <[email protected]> Signed-off-by: Ralph Ursprung <[email protected]> (cherry picked from commit dfa1118)
6 tasks
reta
approved these changes
Oct 24, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #4884 +/- ##
============================================
+ Coverage 70.76% 70.84% +0.08%
- Complexity 57654 57932 +278
============================================
Files 4620 4689 +69
Lines 276150 276913 +763
Branches 40408 40301 -107
============================================
+ Hits 195421 196192 +771
- Misses 64406 64430 +24
+ Partials 16323 16291 -32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
added
the
backport
reta
changed the title
Gradle Check (Jenkins) Run Completed with:
|
seems to be a false reject 😞 |
|
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by convention all supported platforms should also have a gradle target to produce a no-jdk build and that target should be called
no-jdk-[platform].this is a first step in the path to publishing the no-jdk distributions as part of the release, as there are use-cases where a specific JDK should be used instead of the packaged one and it's cleaner to use a small distribution which doesn't bring along an unneeded JDK (the JDK greatly increases the resulting distribution since).
note that i failed to rename the
linux-s390xtarget, it seems that there's too much generic build code out there which tries to stitch together that name and then fails if it doesn't find it.this is part of opensearch-build#99.
Signed-off-by: Ralph Ursprung [email protected]
:distributionthis is primarily to document the JDK & No JDK setup (to codify it for the future), however the README can be extended in the future to document more information which is currently hidden away only somewhere in the code.
Signed-off-by: Ralph Ursprung [email protected]
Signed-off-by: Ralph Ursprung [email protected]
(cherry picked from commit dfa1118)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.