[Extensions]Add query for initialized extensions #5658

mloufra · 2022-12-29T22:44:12Z

Signed-off-by: Frank Lou [email protected]

Description

Create a feature to have an extension query to OpenSearch to obtain a list of initialized extensions and determine whether a particular extension is initialized.
Equivalent PR on OpenSearch-sdk-java : opensearch-project/opensearch-sdk-java#300

Issues Resolved

fixes opensearch-project/opensearch-sdk-java#149

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2022-12-29T22:50:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8607/
CommitID: c5e2ab7
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-29T22:58:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8608/
CommitID: db111f6
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-29T22:59:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8609/
CommitID: bb66d76
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-12-29T23:29:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/8610/
CommitID: b570ecc
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

dbwiddis

Great progress. A few more tweaks needed.

dbwiddis · 2022-12-29T23:40:19Z

server/src/main/java/org/opensearch/extensions/ExtensionRequest.java

 }

 public ExtensionRequest(StreamInput in) throws IOException {
- super(in);


I believe Requests require the super(in) while responses do not. This should definitely match the writeTo implementation; I don't expect it will pass tests without it matching.

dbwiddis · 2022-12-29T23:42:16Z

server/src/main/java/org/opensearch/extensions/ExtensionRequest.java

+ this(requestType, null);
+ }
+
+ public ExtensionRequest(ExtensionsManager.RequestType requestType, Optional<String> uniqueId) {


Don't make the user provide an optional. Just take a @Nullable String parameter here, and then set this.uniqueId the same way you do in the stream constructor. Given the overloaded constructor above, this would set the optional to null and break things later.

dbwiddis · 2022-12-29T23:43:38Z

server/src/main/java/org/opensearch/extensions/ExtensionRequest.java

 }

 @Override
 public boolean equals(Object o) {
 if (this == o) return true;
 if (o == null || getClass() != o.getClass()) return false;
 ExtensionRequest that = (ExtensionRequest) o;
- return Objects.equals(requestType, that.requestType);
+ return Objects.equals(requestType, that.requestType) && uniqueId.equals(that.uniqueId);


(Style) use the same comparison format (either Objects.equals() or direct equals comparison) for both.

dbwiddis · 2022-12-29T23:47:52Z

server/src/main/java/org/opensearch/extensions/ExtensionRequest.java

@@ -24,41 +25,53 @@
 */
 public class ExtensionRequest extends TransportRequest {
 private static final Logger logger = LogManager.getLogger(ExtensionRequest.class);
- private ExtensionsManager.RequestType requestType;
+ private final ExtensionsManager.RequestType requestType;
+ private final Optional<String> uniqueId;


It looks like there is no test class for ExtensionRequest so you should create one and include a test of this uniqueID, both in the null case (single arg constructor) or value present case (two arg constructor)

github-actions · 2022-12-30T00:01:58Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8611/
CommitID: 1c0bc30

codecov-commenter · 2022-12-30T00:04:06Z

Codecov Report

Merging #5658 (cc1f2d9) into main (28e9b11) will decrease coverage by 0.01%.
The diff coverage is 56.52%.

@@             Coverage Diff              @@
##               main    #5658      +/-   ##
============================================
- Coverage     70.98%   70.97%   -0.02%     
- Complexity    58669    58685      +16     
============================================
  Files          4763     4765       +2     
  Lines        279945   280009      +64     
  Branches      40418    40430      +12     
============================================
+ Hits         198731   198738       +7     
- Misses        64988    65084      +96     
+ Partials      16226    16187      -39

Impacted Files	Coverage Δ
.../opensearch/extensions/DiscoveryExtensionNode.java	`74.07% <0.00%> (-21.17%)`	⬇️
...a/org/opensearch/test/OpenSearchIntegTestCase.java	`56.90% <0.00%> (+0.23%)`	⬆️
...a/org/opensearch/extensions/ExtensionsManager.java	`52.45% <22.22%> (-1.59%)`	⬇️
...pensearch/common/settings/FeatureFlagSettings.java	`50.00% <50.00%> (ø)`
...search/extensions/ExtensionDependencyResponse.java	`71.42% <71.42%> (ø)`
...va/org/opensearch/extensions/ExtensionRequest.java	`75.00% <72.72%> (+45.58%)`	⬆️
.../java/org/opensearch/common/util/FeatureFlags.java	`80.00% <88.88%> (+30.00%)`	⬆️
...org/opensearch/common/settings/SettingsModule.java	`85.81% <100.00%> (+0.29%)`	⬆️
server/src/main/java/org/opensearch/node/Node.java	`87.17% <100.00%> (+0.01%)`	⬆️
...g/opensearch/index/analysis/CharFilterFactory.java	`0.00% <0.00%> (-100.00%)`	⬇️
... and 505 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2023-01-04T00:23:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8754/
CommitID: 8937760

github-actions · 2023-01-04T00:31:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8755/
CommitID: 19e666c

server/src/main/java/org/opensearch/extensions/DiscoveryExtensionNode.java

github-actions · 2023-01-04T19:49:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/8814/
CommitID: cc87d2a

saratvemulapalli · 2023-01-04T21:24:35Z

@mloufra can you resolve conflicts with changelog.md?

Signed-off-by: Frank Lou <[email protected]>

github-actions · 2023-01-04T22:52:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testDeleteOperations

URL: https://build.ci.opensearch.org/job/gradle-check/8831/
CommitID: cc1f2d9
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

opensearch-trigger-bot · 2023-01-13T23:56:58Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5658-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e24de72df5cc1ae7a44f84e216518b916f0c7cf5
# Push it to GitHub
git push --set-upstream origin backport/backport-5658-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5658-to-2.x.

andrross · 2023-01-19T21:43:05Z

CHANGELOG.md

@@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Add support for ppc64le architecture ([#5459](https:/opensearch-project/OpenSearch/pull/5459))
 - Added @gbbafna as an OpenSearch maintainer ([#5668](https:/opensearch-project/OpenSearch/pull/5668))
 - Added support for feature flags in opensearch.yml ([#4959](https:/opensearch-project/OpenSearch/pull/4959))
+- Add query for initialized extensions ([#5658](https:/opensearch-project/OpenSearch/pull/5658))


@owaiskazi19 Just a heads up, but since this change was to be backported and released in 2.x, this changelog entry should have gone in the [Unreleased 2.x] section of this file. I'm working on cleaning up the changelog on main right now.

mloufra requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, adnapibar, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng, VachaShah and xuezhou25 as code owners December 29, 2022 22:44

mloufra changed the title ~~[Extensions]Added query for initialized extensions~~ [Extensions]Add query for initialized extensions Dec 29, 2022

mloufra requested a review from dbwiddis December 29, 2022 22:52

dbwiddis requested changes Dec 29, 2022

View reviewed changes

owaiskazi19 reviewed Jan 4, 2023

View reviewed changes

server/src/main/java/org/opensearch/extensions/DiscoveryExtensionNode.java Outdated Show resolved Hide resolved

mloufra added 13 commits January 4, 2023 22:23

query for initialized extensions

0744111

Signed-off-by: Frank Lou <[email protected]>

add changelog

063e79f

Signed-off-by: Frank Lou <[email protected]>

spotless

c98b98c

Signed-off-by: Frank Lou <[email protected]>

delete duplicate variable

217fbaf

Signed-off-by: Frank Lou <[email protected]>

change verify times

158c910

Signed-off-by: Frank Lou <[email protected]>

address comment

119b7c5

Signed-off-by: Frank Lou <[email protected]>

address comment

a58ae99

Signed-off-by: Frank Lou <[email protected]>

address comment

83b9e7f

Signed-off-by: Frank Lou <[email protected]>

address comment

b500a0f

Signed-off-by: Frank Lou <[email protected]>

address comment

3e52ba4

Signed-off-by: Frank Lou <[email protected]>

address comment

09d6137

Signed-off-by: Frank Lou <[email protected]>

address comment

65fe267

Signed-off-by: Frank Lou <[email protected]>

address comment

cc1f2d9

Signed-off-by: Frank Lou <[email protected]>

mloufra force-pushed the query-for-extensions branch from cc87d2a to cc1f2d9 Compare January 4, 2023 22:24

mloufra requested a review from owaiskazi19 January 5, 2023 18:30

owaiskazi19 approved these changes Jan 5, 2023

View reviewed changes

owaiskazi19 merged commit e24de72 into opensearch-project:main Jan 5, 2023

dbwiddis mentioned this pull request Jan 5, 2023

[FEATURE] Let an extension query OpenSearch for all initialized extensions opensearch-project/opensearch-sdk-java#149

Closed

mloufra deleted the query-for-extensions branch January 5, 2023 21:09

ryanbogan added the backport 2.x Backport to 2.x branch label Jan 13, 2023

ryanbogan mentioned this pull request Jan 14, 2023

[Backport 2.x] Add query for initialized extensions #5861

Merged

6 tasks

dbwiddis mentioned this pull request Jan 14, 2023

[META] [FEATURE] Design and build forward compatibility and backward compatibility for SDK opensearch-project/opensearch-sdk-java#338

Closed

2 tasks

andrross reviewed Jan 19, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Extensions]Add query for initialized extensions #5658

[Extensions]Add query for initialized extensions #5658

mloufra commented Dec 29, 2022 •

edited

Loading

github-actions bot commented Dec 29, 2022

github-actions bot commented Dec 29, 2022

github-actions bot commented Dec 29, 2022

github-actions bot commented Dec 29, 2022

dbwiddis left a comment

dbwiddis Dec 29, 2022

dbwiddis Dec 29, 2022

dbwiddis Dec 29, 2022

dbwiddis Dec 29, 2022

github-actions bot commented Dec 30, 2022

codecov-commenter commented Dec 30, 2022 •

edited

Loading

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

saratvemulapalli commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

opensearch-trigger-bot bot commented Jan 13, 2023

andrross Jan 19, 2023

[Extensions]Add query for initialized extensions #5658

[Extensions]Add query for initialized extensions #5658

Conversation

mloufra commented Dec 29, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Dec 29, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 29, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 29, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Dec 29, 2022

Gradle Check (Jenkins) Run Completed with:

dbwiddis left a comment

Choose a reason for hiding this comment

dbwiddis Dec 29, 2022

Choose a reason for hiding this comment

dbwiddis Dec 29, 2022

Choose a reason for hiding this comment

dbwiddis Dec 29, 2022

Choose a reason for hiding this comment

dbwiddis Dec 29, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 30, 2022

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Dec 30, 2022 • edited Loading

Codecov Report

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

saratvemulapalli commented Jan 4, 2023

github-actions bot commented Jan 4, 2023

Gradle Check (Jenkins) Run Completed with:

opensearch-trigger-bot bot commented Jan 13, 2023

andrross Jan 19, 2023

Choose a reason for hiding this comment

mloufra commented Dec 29, 2022 •

edited

Loading

codecov-commenter commented Dec 30, 2022 •

edited

Loading