[Segment Replication] Log diff.different files for debuggability #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
mch2
approved these changes
Jan 27, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
* [Segment Replication] Log diff.different files Signed-off-by: Suraj Singh <[email protected]> * Remove unnecessary conversion Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 8d4bbef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Jan 27, 2023
…) (#6051) * [Segment Replication] Log diff.different files * Remove unnecessary conversion * Spotless fix --------- (cherry picked from commit 8d4bbef) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Feb 3, 2023
Three changes here: - Remove unneeded entry (was removed in backport) (opensearch-project#6049) - Move segrep change to proper section (was put in correct spot in backport) (opensearch-project#6122) - Add back issue that was merged to main prior to 2.5 release but not backported, and was therefore removed from the main CHANGELOG (opensearch-project#4603) Signed-off-by: Andrew Ross <[email protected]>
andrross
added a commit
that referenced
this pull request
Feb 4, 2023
Three changes here: - Remove unneeded entry (was removed in backport) (#6049) - Move segrep change to proper section (was put in correct spot in backport) (#6122) - Add back issue that was merged to main prior to 2.5 release but not backported, and was therefore removed from the main CHANGELOG (#4603) Signed-off-by: Andrew Ross <[email protected]>
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Mar 4, 2023
…nsearch-project#6049) * [Segment Replication] Log diff.different files Signed-off-by: Suraj Singh <[email protected]> * Remove unnecessary conversion Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suraj Singh [email protected]
Description
This change logs the diff.different files for debugging purpose. Coming from #5701 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.