Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search preference based routing for WRR #6834

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Mar 25, 2023

Description

Various enhancements to search preference for Weighed Round Robin shard routing

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the search-pref-routing-enhancement branch from 7473ec0 to d0ae3d8 Compare March 25, 2023 15:15
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #6834 (4be3054) into main (07565ad) will increase coverage by 0.01%.
The diff coverage is 53.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6834      +/-   ##
============================================
+ Coverage     70.65%   70.67%   +0.01%     
- Complexity    59162    59205      +43     
============================================
  Files          4812     4812              
  Lines        283615   283631      +16     
  Branches      40896    40898       +2     
============================================
+ Hits         200394   200443      +49     
+ Misses        66764    66728      -36     
- Partials      16457    16460       +3     
Impacted Files Coverage Δ
...ensearch/cluster/routing/WeightedRoutingUtils.java 68.42% <0.00%> (-8.05%) ⬇️
...rg/opensearch/common/settings/ClusterSettings.java 92.50% <ø> (ø)
...g/opensearch/cluster/routing/OperationRouting.java 80.50% <50.00%> (-0.04%) ⬇️
...arch/cluster/routing/FailAwareWeightedRouting.java 74.41% <62.50%> (-1.90%) ⬇️
...search/cluster/routing/IndexShardRoutingTable.java 87.78% <100.00%> (+0.71%) ⬆️

... and 494 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the search-pref-routing-enhancement branch from 256ba08 to dc9ab0d Compare March 25, 2023 20:23
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the search-pref-routing-enhancement branch from 55ef13d to dc9ab0d Compare March 28, 2023 07:52
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testRelocateWithQueuedOperationsDuringHandoff

Copy link
Collaborator

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we create an issue where we list out the problems which this PR is solving ?

@linuxpi
Copy link
Collaborator Author

linuxpi commented Mar 29, 2023

can we create an issue where we list out the problems which this PR is solving ?

@gbbafna i've created issues corresponding to this PR and updated description

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.shrink/30_copy_settings/Copy settings during shrink index}

@linuxpi linuxpi force-pushed the search-pref-routing-enhancement branch from 4be3054 to 0f7e026 Compare March 30, 2023 07:52
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@gbbafna gbbafna merged commit d8d6e73 into opensearch-project:main Mar 30, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Mar 30, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6834-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8d6e7324adb4be088cab8e1fa5833e18ef19109
# Push it to GitHub
git push --set-upstream origin backport/backport-6834-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6834-to-2.x.

linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Mar 30, 2023
@linuxpi linuxpi mentioned this pull request Mar 30, 2023
6 tasks
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Mar 30, 2023
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Mar 30, 2023
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Apr 3, 2023
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Apr 3, 2023
linuxpi added a commit to linuxpi/OpenSearch that referenced this pull request Apr 3, 2023
gbbafna pushed a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Varun Bansal <[email protected]>
(cherry picked from commit d8d6e73)
mitrofmep pushed a commit to mitrofmep/OpenSearch that referenced this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants