Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Remote Store] Moving stale commit deletion to async fl… #8442

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

psychbot
Copy link
Member

@psychbot psychbot commented Jul 5, 2023

…ow (#8201)


Description

Backporting #8201 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #8442 (d6859b8) into 2.x (b110ada) will decrease coverage by 0.02%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##                2.x    #8442      +/-   ##
============================================
- Coverage     70.62%   70.60%   -0.02%     
+ Complexity    57014    57013       -1     
============================================
  Files          4737     4737              
  Lines        270092   270103      +11     
  Branches      39905    39905              
============================================
- Hits         190759   190716      -43     
- Misses        62905    63038     +133     
+ Partials      16428    16349      -79     
Impacted Files Coverage Δ
...in/java/org/opensearch/index/shard/IndexShard.java 68.78% <0.00%> (-0.17%) ⬇️
...java/org/opensearch/index/shard/StoreRecovery.java 57.25% <0.00%> (-0.95%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 85.05% <100.00%> (-4.90%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 91.91% <100.00%> (+1.86%) ⬆️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 95.65% <100.00%> (+0.19%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 85.08% <100.00%> (ø)

... and 479 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 9b9718f into opensearch-project:2.x Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants