[Segment Replication] Remove testUpdateSegmentsWhileRefreshing flaky test failure

[dreamer-89]

Description

Deleting testUpdateSegmentsWhileRefreshing test as it flaky and not needed anymore. The original PR where logic to perform blocking refresh on NRTReaderManager was added, got removed in follow up PR #8859.

Related Issues

Resolves #8941

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[mch2]

Thanks for catching this!

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/21208/
• CommitID: 90f2f3f
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dreamer-89]

testIndexDeletionDuringSnapshotCreationInQueue -> #5031

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

• URL: https://build.ci.opensearch.org/job/gradle-check/21217/
• CommitID: 90f2f3f
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #8943 (90f2f3f) into main (91bc891) will decrease coverage by 0.06%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8943      +/-   ##
============================================
- Coverage     71.05%   71.00%   -0.06%     
- Complexity    57198    57201       +3     
============================================
  Files          4758     4758              
  Lines        269863   269863              
  Branches      39484    39484              
============================================
- Hits         191755   191615     -140     
- Misses        61982    62100     +118     
- Partials      16126    16148      +22     

see 464 files with indirect coverage changes