[Remote Store] Changes to perform repository registration during bootstrap via node attributes.

[psychbot]

Description

Solves #8623
The changes are to perform repository registration via the values supplied in node attributes during node bootstap.
Reject or accept the join request if they have matchin node attributes.

Below are the format in which the node attributes will be supplied.

Config 1

node.attr.remote_store.segment.repository : remote-store-A
node.attr.remote_store.repository.remote-store-A.type : s3
node.attr.remote_store.repository.remote-store-A.settings : 
        bucket : abc
        base_path : xyz
node.attr.remote_store.translog.repository : remote-store-B
node.attr.remote_store.repository.remote-store-B.type : hdfs
node.attr.remote_store.repository.remote-store-B.settings : 
        uri : blah
        base_path : foo

Config 2

node.attr.remote_store.segment.repository : remote-store-A
node.attr.remote_store.repository.remote-store-A.type : s3
node.attr.remote_store.repository.remote-store-A.settings : 
        bucket : abc
        base_path : xyz
node.attr.remote_store.translog.repository : remote-store-A

Related

Resolves #8623

Pending Items

• Error Handling
• Repository Verification
• Unit Tests
• Integ Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/21838/
• CommitID: 972b0b5
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https:/opensearch-project/security-analytics.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/performance-analyzer.git]
Compatible components: [https:/opensearch-project/geospatial.git, https:/opensearch-project/security.git, https:/opensearch-project/notifications.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/index-management.git, https:/opensearch-project/sql.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/observability.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/alerting.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/reporting.git]

BUILD SUCCESSFUL in 28m 9s

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/sql.git, https:/opensearch-project/index-management.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/notifications.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/performance-analyzer.git]
Compatible components: [https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 25m 27s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22347/
• CommitID: 77af2c5
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[Bukhtawar]

How about simplifying the configurations to

      - cluster.system_repositories.segment: "remote-segment-repo"
      - cluster.system_repositories.translog: "remote-translog-repo"
      - node.attr.remote-segment-repo :
            - type : s3
               settings
                    - bucket : bucket_name
                       base_path : xyz/abc
      - node.attr.remote-translog-repo :
            - type : s3
               settings
                    - bucket : bucket_name
                       base_path : xyz/abc

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22755/
• CommitID: 0442656
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https:/opensearch-project/alerting.git, https:/opensearch-project/index-management.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/observability.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/notifications.git, https:/opensearch-project/security-analytics.git]
Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/sql.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/reporting.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 27m 35s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22757/
• CommitID: e89fbcf
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[ashking94]

Pls add more comments on the places where we are updating the cluster state. Specifically where a condition evaluates to true and we update the state. It would help understand under what circumstances it would update the state.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22982/
• CommitID: bcf8ef3
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

Compatibility status:

Checks if related components are compatible with change 6a5b464

Incompatible components

Incompatible components: [https:/opensearch-project/index-management.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/sql.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/observability.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/reporting.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/notifications.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/opensearch-oci-object-storage.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/24497/
• CommitID: 899ae5d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[psychbot]

Flaky test failing in gradle check - org.opensearch.common.blobstore.stream.read.listener.ReadContextListenerTests.testReadContextListenerFailure
#9776

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/24552/
• CommitID: 8c54a86
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/24551/
• CommitID: 899ae5d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 8c54a86

Incompatible components

Incompatible components: [https:/opensearch-project/sql.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/index-management.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/observability.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/reporting.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/notifications.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/opensearch-oci-object-storage.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/24559/
• CommitID: 8c54a86
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[gbbafna]

The test org.opensearch.search.profile.query.QueryProfilerIT.testProfileMatchesRegular {p0={"search.concurrent_segment_search.enabled":"true"} p1=true} passed in the previous run and failed in this and is flaky .

[psychbot]

A different test is flaky now - org.opensearch.search.profile.query.QueryProfilerIT.testProfileMatchesRegular {p0={"search.concurrent_segment_search.enabled":"true"} p1=true}
#9787

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9105-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9119b6dc20ea11d95a399c68505f1d858b78e30e
# Push it to GitHub
git push --set-upstream origin backport/backport-9105-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9105-to-2.x.