Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the script sort related ITs #9466

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

neetikasinghal
Copy link
Contributor

@neetikasinghal neetikasinghal commented Aug 21, 2023

Description

Solves the sort related ITs

Related Issues

Resolves #8510

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 61c5f17

Incompatible components

Incompatible components: [https:/opensearch-project/index-management.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/notifications.git, https:/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/sql.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/observability.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/reporting.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/opensearch-oci-object-storage.git]

@sohami sohami added the backport 2.x Backport to 2.x branch label Aug 22, 2023
@neetikasinghal
Copy link
Contributor Author

@reta waiting for your review.

@sohami
Copy link
Collaborator

sohami commented Aug 23, 2023

@reta waiting for your review.

@reta planning to merge it today unless you have some feedback.

@reta
Copy link
Collaborator

reta commented Aug 23, 2023

@reta waiting for your review.

@reta planning to merge it today unless you have some feedback.

@neetikasinghal sincere apologies, added few comments but LGTM as approach (have nothing better to suggest)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change d1678ba

Incompatible components

Incompatible components: [https:/opensearch-project/index-management.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/notifications.git, https:/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/sql.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/observability.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/reporting.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search.aggregation/20_terms/string profiler via global ordinals}

@sohami sohami merged commit a6c0bb3 into opensearch-project:main Aug 24, 2023
10 of 11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9466-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6c0bb30f93db1c0d5204211273650dfb6eda7d4
# Push it to GitHub
git push --set-upstream origin backport/backport-9466-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9466-to-2.x.

austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concurrent Segment Search] Fix Sort related ITs
3 participants