Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Removing version checks from RemoteSegmentStats #9545

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

shourya035
Copy link
Member

Description

Removing version checks from RemoteSegmentStats to retain BwC. This PR should be followed after #9544 is merged

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shourya Dutta Biswas <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Shourya Dutta Biswas <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #9545 (7b7dd88) into main (c90b6ea) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9545      +/-   ##
============================================
- Coverage     71.15%   71.06%   -0.10%     
+ Complexity    57485    57435      -50     
============================================
  Files          4778     4778              
  Lines        270981   270979       -2     
  Branches      39585    39583       -2     
============================================
- Hits         192823   192577     -246     
- Misses        61941    62199     +258     
+ Partials      16217    16203      -14     
Files Changed Coverage Δ
...rg/opensearch/index/remote/RemoteSegmentStats.java 98.24% <100.00%> (+1.69%) ⬆️

... and 469 files with indirect coverage changes

@Bukhtawar Bukhtawar merged commit 72ef73e into opensearch-project:main Aug 25, 2023
13 of 40 checks passed
@shourya035 shourya035 deleted the rs-stats-version-check branch August 25, 2023 12:03
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
…earch-project#9545)

* Removing version checks

Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
…earch-project#9545)

* Removing version checks

Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…earch-project#9545)

* Removing version checks

Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…earch-project#9545)

* Removing version checks

Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…earch-project#9545)

* Removing version checks

Signed-off-by: Shourya Dutta Biswas <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants