Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]rename to time series analytics #864

Open
1 task
kaituo opened this issue Apr 15, 2023 · 5 comments
Open
1 task

[FEATURE]rename to time series analytics #864

kaituo opened this issue Apr 15, 2023 · 5 comments
Labels
feature new feature

Comments

@kaituo
Copy link
Collaborator

kaituo commented Apr 15, 2023

Is your feature request related to a problem?
Rename AD plugin to time series analytics plugin

What solution would you like?
Change name in various places including:

  • ADCommonName.AD_PLUGIN_NAME and AD_PLUGIN_NAME_FOR_TEST. Doing it incorrectly will cause HashRing failing to initialize circles and thus fail tests like AnomalyDetectorJobTransportActionTests.

Do you have any additional context?
opensearch-project/opensearch-build#2880

@kaituo
Copy link
Collaborator Author

kaituo commented Jul 13, 2023

Answering Tyler's question in #951

  • list of repos that will require changes: opensearch-build, dashboard functional test (the test finder that Peter wrote)
  • timeline & targeted version release: 2.12
  • how frontend will be affected or refactored: frontend should not be affected as it talks to backend using service end point like localhost:9200
  • documentation updates: will talk to documentation team
  • github repo name change: will talk to infra team. Have already synced up with them before.

@ohltyler
Copy link
Member

For the list of repos that require changes, I was more wondering about the future/eventual changes that will need to be done in frontend or other plugins, such as updating naming, refactoring of the frontend plugin itself, and I'm assuming updated API paths which may affect alerting as well.

@ohltyler
Copy link
Member

For the list of repos that require changes, I was more wondering about the future/eventual changes that will need to be done in frontend or other plugins, such as updating naming, refactoring of the frontend plugin itself, and I'm assuming updated API paths which may affect alerting as well.

Maybe a lot of this hasn't been detailed out yet, but could be helpful to have a high-level plan to get an idea on where things are headed

@kaituo
Copy link
Collaborator Author

kaituo commented Jul 13, 2023

For the list of repos that require changes, I was more wondering about the future/eventual changes that will need to be done in frontend or other plugins, such as updating naming, refactoring of the frontend plugin itself, and I'm assuming updated API paths which may affect alerting as well.

We will start updating frontend plugin name after backend has been settled. I may not refactor a lot of frontend plugin code as I did for backend. I don't plan to update API paths for AD. Forecasting has its own API paths and the new code in the frontend will use the new paths.

@kaituo
Copy link
Collaborator Author

kaituo commented Jul 13, 2023

For the list of repos that require changes, I was more wondering about the future/eventual changes that will need to be done in frontend or other plugins, such as updating naming, refactoring of the frontend plugin itself, and I'm assuming updated API paths which may affect alerting as well.

Maybe a lot of this hasn't been detailed out yet, but could be helpful to have a high-level plan to get an idea on where things are headed

yeah, high level plan for backend is:
1)rename in main branch;
2)reach out to infra team and make changes (e.g., repo name, opensearch-build repo)
3)backport to 2.10 (maybe delayed).
4)documentation change

for the frontend, I might just start with repo name change and not change plugin name yet. Will do it after all backend changes are settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

3 participants