Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RCF Version and Fix Default Rules Bug in AnomalyDetector #1334

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Oct 11, 2024

Description

  • Updated RCF version to the latest release.
  • Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:

  • Added unit tests to cover the bug fix

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (5704a16) to head (5a2ab92).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1334      +/-   ##
============================================
+ Coverage     79.57%   79.73%   +0.16%     
- Complexity     5627     5639      +12     
============================================
  Files           533      533              
  Lines         23410    23410              
  Branches       2323     2323              
============================================
+ Hits          18628    18667      +39     
+ Misses         3680     3639      -41     
- Partials       1102     1104       +2     
Flag Coverage Δ
plugin 79.73% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.33% <100.00%> (ø)
...n/java/org/opensearch/timeseries/JobProcessor.java 82.78% <ø> (ø)
...ensearch/timeseries/ratelimit/ColdStartWorker.java 91.07% <100.00%> (ø)
...timeseries/rest/handler/IndexJobActionHandler.java 89.27% <ø> (+1.71%) ⬆️
...s/transport/handler/ResultBulkIndexingHandler.java 93.05% <100.00%> (+19.44%) ⬆️

... and 9 files with indirect coverage changes

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
@kaituo kaituo merged commit 2ab6dc7 into opensearch-project:main Oct 11, 2024
20 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2024
* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 2ab6dc7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.17
# Create a new branch
git switch --create backport/backport-1334-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2ab6dc7f034947ef10a3ca0c422ca41a646c511b
# Push it to GitHub
git push --set-upstream origin backport/backport-1334-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-1334-to-2.17.

kaituo added a commit to kaituo/anomaly-detection-1 that referenced this pull request Oct 11, 2024
…arch-project#1334)

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this pull request Oct 11, 2024
…arch-project#1334)

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
kaituo added a commit that referenced this pull request Oct 11, 2024
…#1336)

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.17 backport-failed infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants