Add rule validation in AnomalyDetector constructor #1341
Merged
+669
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces rule validation within the AnomalyDetector constructor. Any validation errors are now propagated and displayed on the frontend to ensure immediate feedback. Testing: * Verified that validation errors are properly propagated and shown on the frontend. * Added UTs to cover the new validation logic. Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
opensearch-trigger-bot
bot
added
infra
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
============================================
+ Coverage 79.68% 80.08% +0.39%
- Complexity 5630 5675 +45
============================================
Files 533 533
Lines 23410 23429 +19
Branches 2323 2335 +12
============================================
+ Hits 18654 18762 +108
+ Misses 3651 3563 -88
+ Partials 1105 1104 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitgalitz
reviewed
Oct 18, 2024
| * @param configId config Id | ||
| * @return a map of model id to its memory size | ||
| */ | ||
| public Map<String, Long> getModelSize(String configId) { |
There was a problem hiding this comment.
where these just never used anymore?
There was a problem hiding this comment.
yeah, they are not used after recent refactoring.
amitgalitz
reviewed
Oct 18, 2024
|
|
||
| // Null check for features | ||
| if (features == null) { | ||
| // Cannot proceed with validation if features are null but rules are not null |
There was a problem hiding this comment.
nit: could add || features.isEmpty() same we do for rules above
amitgalitz
reviewed
Oct 18, 2024
| // Null check for features | ||
| if (features == null) { | ||
| // Cannot proceed with validation if features are null but rules are not null | ||
| this.errorMessage = "Suppression Rule Error: Features are not defined while suppression rules are provided."; |
There was a problem hiding this comment.
nit: "Suppression Rule Error" can be put in a constant
amitgalitz
reviewed
Oct 18, 2024
| || thresholdType == ThresholdType.EXPECTED_OVER_ACTUAL_RATIO) { | ||
| // Check if the value is not NaN | ||
| double value = condition.getValue(); | ||
| if (Double.isNaN(value)) { |
There was a problem hiding this comment.
btw I will be changing value section to be okay with Null if threshold type is ACTUAL_IS_OVER_EXPECTED or EXPECTED_IS_OVER_ACTUAL. Will make sure those aren't passed to RCF and seen as not a rule in that case later on too
amitgalitz
previously approved these changes
Oct 18, 2024
Signed-off-by: Kaituo Li <[email protected]>
amitgalitz
approved these changes
Oct 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Add rule validation in AnomalyDetector constructor This commit introduces rule validation within the AnomalyDetector constructor. Any validation errors are now propagated and displayed on the frontend to ensure immediate feedback. Testing: * Verified that validation errors are properly propagated and shown on the frontend. * Added UTs to cover the new validation logic. Signed-off-by: Kaituo Li <[email protected]> * address Amit's comments Signed-off-by: Kaituo Li <[email protected]> --------- Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 9cdbcee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Add rule validation in AnomalyDetector constructor This commit introduces rule validation within the AnomalyDetector constructor. Any validation errors are now propagated and displayed on the frontend to ensure immediate feedback. Testing: * Verified that validation errors are properly propagated and shown on the frontend. * Added UTs to cover the new validation logic. * address Amit's comments --------- (cherry picked from commit 9cdbcee) Signed-off-by: Kaituo Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces rule validation within the AnomalyDetector constructor. Any validation errors are now propagated and displayed on the frontend to ensure immediate feedback.
Testing:
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.