Skip to content

Commit

Permalink
update reporting UI and handle new navigation
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Tackett <[email protected]>
  • Loading branch information
Adam Tackett committed Sep 4, 2024
1 parent 0af5edd commit 325a43b
Show file tree
Hide file tree
Showing 16 changed files with 472 additions and 2,507 deletions.
20 changes: 5 additions & 15 deletions public/components/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,16 @@
*/

import React from 'react';
import { FormattedMessage, I18nProvider } from '@osd/i18n/react';
import { I18nProvider } from '@osd/i18n/react';
import { HashRouter as Router, Route, Switch } from 'react-router-dom';

import {

Check failure on line 10 in public/components/app.tsx

View workflow job for this annotation

GitHub Actions / Lint

Replace `⏎··EuiPage,⏎··EuiPageBody,⏎··EuiPageContentBody,⏎` with `·EuiPage,·EuiPageBody,·EuiPageContentBody·`
EuiPage,
EuiPageBody,
EuiPageContentBody,
EuiPageContentHeader,
EuiPageContentHeaderSection,
} from '@elastic/eui';
import CSS from 'csstype';
import {
CoreStart,
CoreSystem,
ChromeBreadcrumb,
IUiSettingsClient,
} from '../../../../src/core/public';
Expand All @@ -44,12 +40,6 @@ interface ReportsDashboardsAppDeps {
chrome: CoreStart['chrome'];
}

const styles: CSS.Properties = {
float: 'left',
width: '100%',
maxWidth: '1600px',
};

export const ReportsDashboardsApp = ({
basename,
notifications,

Check failure on line 45 in public/components/app.tsx

View workflow job for this annotation

GitHub Actions / Lint

'notifications' is defined but never used. Allowed unused args must match /^_/u
Expand All @@ -61,12 +51,9 @@ export const ReportsDashboardsApp = ({
return (
<Router basename={'/' + basename}>
<I18nProvider>
<div style={styles}>
<div>
<EuiPage>
<EuiPageBody>
<EuiPageContentHeader>
<EuiPageContentHeaderSection></EuiPageContentHeaderSection>
</EuiPageContentHeader>
<EuiPageContentBody>
<Switch>
<Route
Expand All @@ -78,6 +65,7 @@ export const ReportsDashboardsApp = ({
{ defaultMessage: 'Report Details' }
)}
httpClient={http}
chrome={chrome}
{...props}
setBreadcrumbs={chrome.setBreadcrumbs}
/>
Expand All @@ -92,6 +80,7 @@ export const ReportsDashboardsApp = ({
{ defaultMessage: 'Report Definition Details' }
)}
httpClient={http}
chrome={chrome}
{...props}
setBreadcrumbs={chrome.setBreadcrumbs}
/>
Expand All @@ -106,6 +95,7 @@ export const ReportsDashboardsApp = ({
{ defaultMessage: 'Create Report' }
)}
httpClient={http}
chrome={chrome}
{...props}
setBreadcrumbs={chrome.setBreadcrumbs}
/>
Expand Down
Loading

0 comments on commit 325a43b

Please sign in to comment.