Remove _primary preference from get/mget requests #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
============================================
+ Coverage 88.48% 88.59% +0.10%
Complexity 752 752
============================================
Files 92 92
Lines 2718 2717 -1
Branches 221 221
============================================
+ Hits 2405 2407 +2
+ Misses 232 230 -2
+ Partials 81 80 -1
|
naveentatikonda
approved these changes
Aug 30, 2023
junqiu-lei
approved these changes
Aug 30, 2023
|
@dreamer-89 can you please add CHANGELOG for this change. Also, should we backport this to 2.10 ? |
naveentatikonda
added
backport 2.x
naveentatikonda
merged commit 66c3320
into
opensearch-project:main
19 of 31 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 66c3320)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 66c3320)
naveentatikonda
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 66c3320) Co-authored-by: Suraj Singh <[email protected]>
naveentatikonda
pushed a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 66c3320) Co-authored-by: Suraj Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With opensearch-project/OpenSearch#8536, core now ensures realtime reads for segment replication enabled indices as well. Thus, there is no need to pass
_primarypreference for get/mget requests.Issues Resolved
#346
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.