Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download JS zip when integTest is running #334

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu [email protected]

Issue #, if available:
#333

Description of changes:
Only download JS zip when integTest is running

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

build.gradle Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #334 (e911303) into main (6259f9a) will increase coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #334      +/-   ##
============================================
+ Coverage     76.60%   76.79%   +0.19%     
+ Complexity     2050     2049       -1     
============================================
  Files           253      253              
  Lines         11642    11642              
  Branches       1808     1808              
============================================
+ Hits           8918     8941      +23     
+ Misses         1753     1733      -20     
+ Partials        971      968       -3     
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Chime.kt 43.47% <0.00%> (-17.40%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 75.22% <0.00%> (-0.31%) ⬇️
...earch/indexmanagement/transform/model/Transform.kt 85.47% <0.00%> (ø)
.../opensearch/indexmanagement/rollup/model/Rollup.kt 86.97% <0.00%> (+0.93%) ⬆️
...nt/rollup/action/stop/TransportStopRollupAction.kt 77.64% <0.00%> (+1.17%) ⬆️
...ndexstatemanagement/IndexStateManagementHistory.kt 80.00% <0.00%> (+1.37%) ⬆️
.../rollup/action/start/TransportStartRollupAction.kt 75.29% <0.00%> (+3.52%) ⬆️
...statemanagement/model/destination/CustomWebhook.kt 95.71% <0.00%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6259f9a...e911303. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

Interesting that bwc test success on my local while instantly fail in github actions.

@peterzhuamazon peterzhuamazon force-pushed the opensearch-2.0.0-download-js-zip-only-in-integTest branch from 873c7c0 to 1e5faa0 Compare April 15, 2022 03:26
@dblock dblock merged commit 9ea7a4f into opensearch-project:main Apr 15, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-2.0.0-download-js-zip-only-in-integTest branch April 15, 2022 16:25
wuychn pushed a commit to ochprince/index-management that referenced this pull request Mar 16, 2023
* Move download into integTest task section

Signed-off-by: Peter Zhu <[email protected]>

* Make sure the zip only download when integTest runs

Signed-off-by: Peter Zhu <[email protected]>

* Make sure all 3 artifacts are downloaded during bwc test

Signed-off-by: Peter Zhu <[email protected]>

* Make sure the zip only download when integTest runs

Signed-off-by: Peter Zhu <[email protected]>

* Make sure all 3 artifacts are downloaded during bwc test

Signed-off-by: Peter Zhu <[email protected]>

* Add more changes

Signed-off-by: Peter Zhu <[email protected]>

* More tweaks

Signed-off-by: Peter Zhu <[email protected]>

* Remove comments

Signed-off-by: Peter Zhu <[email protected]>

* Add back comments

Signed-off-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][DISTRIBUTION][2.0.0] IM downloading JS zip that is not exist due to no success builds
5 participants