Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.gradle to include job-scheduler jar when staging maven publications. #117

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Jan 11, 2022

Signed-off-by: Marc Handalian [email protected]

Description

  • updates build.gradle to ensure the base jar has the required pom fields for publishing to maven central.
  • updates to include this jar when publishing to the local staging repository currently used by CI to pick up artifacts for promotion.
  • Updates developer on spi jar to be opensearch.
  • Updates build.sh script to be in sync with the script in opensearch-build. The version of this script in this repo is a backup, a separate PR will be made to opensearch-build.

Issues Resolved

closes #114

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mch2 mch2 requested a review from a team January 11, 2022 20:49
dblock
dblock previously approved these changes Jan 12, 2022
build.gradle Outdated Show resolved Hide resolved
spi/build.gradle Outdated Show resolved Hide resolved
@mch2
Copy link
Member Author

mch2 commented Jan 12, 2022

Not sure whats going on here with the build workflow. I'm getting the same thing locally. It should be pulling these deps from aws.oss, this repo has no reference to jcenter that I can see.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Could not resolve all files for configuration ':testCompileClasspath'.
   > Could not resolve org.opensearch.test:framework:1.3.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.opensearch.test:framework:1.3.0-SNAPSHOT.
         > Unable to load Maven meta-data from https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml.
            > Could not get resource 'https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml'.
               > Could not GET 'https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml'. Received status code 502 from server: Bad Gateway

@saratvemulapalli
Copy link
Member

Not sure whats going on here with the build workflow. I'm getting the same thing locally. It should be pulling these deps from aws.oss, this repo has no reference to jcenter that I can see.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Could not resolve all files for configuration ':testCompileClasspath'.
   > Could not resolve org.opensearch.test:framework:1.3.0-SNAPSHOT.
     Required by:
         project :
      > Could not resolve org.opensearch.test:framework:1.3.0-SNAPSHOT.
         > Unable to load Maven meta-data from https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml.
            > Could not get resource 'https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml'.
               > Could not GET 'https://jcenter.bintray.com/org/opensearch/test/framework/1.3.0-SNAPSHOT/maven-metadata.xml'. Received status code 502 from server: Bad Gateway

Yup the repo doesn't have Jcenter configured, do you think its being pulled by ShadowPlugin?

@mch2
Copy link
Member Author

mch2 commented Jan 12, 2022

@mch2
Copy link
Member Author

mch2 commented Jan 13, 2022

Looks like the changes to Opensearch 1.x fix the build, I no longer see Bintray as a repo option.

2022-01-13T09:32:11.407-0800 [DEBUG] [org.gradle.api.internal.artifacts.ivyservice.ivyresolve.RepositoryChainComponentMetaDataResolver] Attempting to resolve component for org.apache.httpcomponents:httpcore-nio:4.4.12 using repositories [MavenRepo, MavenRepo2, opensearch-downloads, opensearch-downloads2, opensearch-snapshots, elasticsearch-downloads, elasticsearch-snapshots, MavenLocal, MavenRepo3, maven]

…lications.

This change updates build.gradle to ensure the base jar has the required pom fields for publishing to maven central.
It also updates to include this jar when publishing to a local staging repository currently used by CI to pick up artifacts for promotion.

Signed-off-by: Marc Handalian <[email protected]>
@dblock dblock merged commit a67e734 into opensearch-project:main Jan 13, 2022
@mch2 mch2 deleted the pomfix branch January 13, 2022 19:19
@amitgalitz amitgalitz mentioned this pull request Jan 31, 2022
1 task
amitgalitz pushed a commit to amitgalitz/job-scheduler that referenced this pull request Feb 2, 2022
…lications. (opensearch-project#117)

This change updates build.gradle to ensure the base jar has the required pom fields for publishing to maven central.
It also updates to include this jar when publishing to a local staging repository currently used by CI to pick up artifacts for promotion.

Signed-off-by: Marc Handalian <[email protected]>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
…lications. (opensearch-project#117)

This change updates build.gradle to ensure the base jar has the required pom fields for publishing to maven central.
It also updates to include this jar when publishing to a local staging repository currently used by CI to pick up artifacts for promotion.

Signed-off-by: Marc Handalian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish job-scheduler JAR to maven, not only -spi
3 participants