Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation errors after changes in core foundation classes #1202

Conversation

martin-gaievski
Copy link
Member

Description

Fixed compilation errors after refactoring in core foundation classes (opensearch-project/OpenSearch#9082)

Check List

  • All tests pass
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski force-pushed the fix-compilation-errors-after-changes-in-core branch from 4c373db to 2e8c075 Compare August 11, 2023 19:29
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1202 (2e8c075) into main (730f21c) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1202      +/-   ##
============================================
- Coverage     84.12%   84.09%   -0.03%     
+ Complexity     1755     1753       -2     
============================================
  Files           139      139              
  Lines          6716     6716              
  Branches        669      669              
============================================
- Hits           5650     5648       -2     
- Misses          769      771       +2     
  Partials        297      297              
Flag Coverage Δ
ml-commons 84.09% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rg/opensearch/ml/client/MachineLearningClient.java 100.00% <ø> (ø)
...pensearch/ml/client/MachineLearningNodeClient.java 96.07% <ø> (ø)
...ain/java/org/opensearch/ml/engine/ModelHelper.java 87.61% <ø> (ø)
...thms/anomalylocalization/AnomalyLocalizerImpl.java 97.63% <ø> (ø)
...rithms/metrics_correlation/MetricsCorrelation.java 82.39% <ø> (ø)
...h/ml/action/deploy/TransportDeployModelAction.java 84.55% <ø> (ø)
...ction/deploy/TransportDeployModelOnNodeAction.java 97.40% <ø> (ø)
.../ml/action/execute/TransportExecuteTaskAction.java 100.00% <ø> (ø)
...arch/ml/action/forward/TransportForwardAction.java 95.60% <ø> (ø)
.../opensearch/ml/action/handler/MLSearchHandler.java 86.66% <ø> (ø)
... and 31 more

@MitchellGale
Copy link
Contributor

Hi @martin-gaievski, this was addressed and merged in #1200 :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants